Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1170873003: Make the GN use_glib argument not user-selectable. (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the GN use_glib argument not user-selectable. The interaction between use_ozone and use_glib was awkward when they were both declared as GN arguments, and there doesn't seem to be a good reason for use_glib to be user-togglable. R=brettw@chromium.org BUG= Committed: https://crrev.com/9de174326a0c2a391ce4a6712f70e53712536bc3 Cr-Commit-Position: refs/heads/master@{#333544}

Patch Set 1 #

Patch Set 2 : fix references to use_cairo and use_pango #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M build/config/ui.gni View 1 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Dirk Pranke
5 years, 6 months ago (2015-06-09 02:00:41 UTC) #1
brettw
lgtm
5 years, 6 months ago (2015-06-09 15:34:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170873003/1
5 years, 6 months ago (2015-06-09 15:56:30 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/79517) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 6 months ago (2015-06-09 16:06:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170873003/20001
5 years, 6 months ago (2015-06-09 18:24:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 19:05:04 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 19:06:05 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9de174326a0c2a391ce4a6712f70e53712536bc3
Cr-Commit-Position: refs/heads/master@{#333544}

Powered by Google App Engine
This is Rietveld 408576698