Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1170863006: Label some unused static vars as SK_UNUSED (Closed)

Created:
5 years, 6 months ago by f(malita)
Modified:
5 years, 6 months ago
Reviewers:
mtklein, scroggo, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Label some unused static vars as SK_UNUSED Makes my gcc 5.1.1 much happier. R=mtklein@google.com,scroggo@google.com [ mtklein mischief below here ] No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/523beb7fd91e6a171a69f44cf6cc8e8d88a22dd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M include/images/SkForceLinking.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommandLineFlags.h View 1 chunk +28 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
f(malita)
5 years, 6 months ago (2015-06-10 17:05:22 UTC) #1
mtklein
lgtm
5 years, 6 months ago (2015-06-10 17:16:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170863006/1
5 years, 6 months ago (2015-06-10 17:16:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/374)
5 years, 6 months ago (2015-06-10 17:17:29 UTC) #6
f(malita)
On 2015/06/10 17:17:29, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-10 17:18:48 UTC) #8
scroggo
lgtm
5 years, 6 months ago (2015-06-10 17:27:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170863006/1
5 years, 6 months ago (2015-06-10 17:35:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/377)
5 years, 6 months ago (2015-06-10 17:36:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170863006/1
5 years, 6 months ago (2015-06-10 17:46:13 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 17:46:53 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/523beb7fd91e6a171a69f44cf6cc8e8d88a22dd0

Powered by Google App Engine
This is Rietveld 408576698