Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: Source/core/html/HTMLOptionElement.h

Issue 1170843003: Don't force a <select> repaint whenever an <option> changes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Moar rebaselines. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) 2010 Google Inc. All rights reserved. 6 * Copyright (C) 2010 Google Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override; 85 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
86 virtual void didNotifySubtreeInsertionsToDocument() override; 86 virtual void didNotifySubtreeInsertionsToDocument() override;
87 virtual void removedFrom(ContainerNode*) override; 87 virtual void removedFrom(ContainerNode*) override;
88 virtual void accessKeyAction(bool) override; 88 virtual void accessKeyAction(bool) override;
89 virtual void childrenChanged(const ChildrenChange&) override; 89 virtual void childrenChanged(const ChildrenChange&) override;
90 90
91 // <option> never has a layoutObject so we manually manage a cached style. 91 // <option> never has a layoutObject so we manually manage a cached style.
92 void updateNonComputedStyle(); 92 void updateNonComputedStyle();
93 virtual ComputedStyle* nonLayoutObjectComputedStyle() const override; 93 virtual ComputedStyle* nonLayoutObjectComputedStyle() const override;
94 virtual PassRefPtr<ComputedStyle> customStyleForLayoutObject() override; 94 virtual PassRefPtr<ComputedStyle> customStyleForLayoutObject() override;
95 virtual void didRecalcStyle(StyleRecalcChange) override;
96 virtual void didAddUserAgentShadowRoot(ShadowRoot&) override; 95 virtual void didAddUserAgentShadowRoot(ShadowRoot&) override;
97 96
98 String collectOptionInnerText() const; 97 String collectOptionInnerText() const;
99 98
100 void updateLabel(); 99 void updateLabel();
101 100
102 bool m_disabled; 101 bool m_disabled;
103 bool m_isSelected; 102 bool m_isSelected;
104 RefPtr<ComputedStyle> m_style; 103 RefPtr<ComputedStyle> m_style;
105 }; 104 };
106 105
107 } // namespace blink 106 } // namespace blink
108 107
109 #endif // HTMLOptionElement_h 108 #endif // HTMLOptionElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698