Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1170843003: Don't force a <select> repaint whenever an <option> changes. (Closed)

Created:
4 years, 10 months ago by esprehn
Modified:
4 years, 10 months ago
Reviewers:
tkent, pdr., Xianzhu
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't force a <select> repaint whenever an <option> changes. Now that <select> uses Shadow DOM to manage the options we don't need to unconditionally repaint the select whenever an <option> element goes through a style recalc. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196796

Patch Set 1 #

Patch Set 2 : TestExpectations. #

Patch Set 3 : Moar rebaselines. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +5 lines, -0 lines 1 comment Download
M Source/core/html/HTMLOptionElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170843003/1
4 years, 10 months ago (2015-06-08 21:53:50 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/58100)
4 years, 10 months ago (2015-06-08 23:15:59 UTC) #4
esprehn
On 2015/06/08 at 23:15:59, commit-bot wrote: > Dry run: Try jobs failed on following builders: ...
4 years, 10 months ago (2015-06-08 23:26:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170843003/20001
4 years, 10 months ago (2015-06-08 23:57:13 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/65612)
4 years, 10 months ago (2015-06-09 01:54:59 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170843003/40001
4 years, 10 months ago (2015-06-09 02:32:14 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-09 03:31:27 UTC) #13
esprehn
ping
4 years, 10 months ago (2015-06-09 19:53:13 UTC) #15
pdr.
LGTM https://codereview.chromium.org/1170843003/diff/40001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1170843003/diff/40001/LayoutTests/TestExpectations#newcode100 LayoutTests/TestExpectations:100: Bug(esprehn) fast/repaint/select-option-background-color.html [ NeedsRebaseline ] Did these already ...
4 years, 10 months ago (2015-06-09 19:59:54 UTC) #16
pdr.
On 2015/06/09 at 19:59:54, pdr wrote: > LGTM > > https://codereview.chromium.org/1170843003/diff/40001/LayoutTests/TestExpectations > File LayoutTests/TestExpectations (right): ...
4 years, 10 months ago (2015-06-09 20:00:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170843003/40001
4 years, 10 months ago (2015-06-09 20:25:57 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 20:29:28 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196796

Powered by Google App Engine
This is Rietveld 408576698