Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9616)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

Issue 1170843002: [Andorid] Migrate to ClipDrawable progress bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ChromeShell test fix 2 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
index d1500bcdf19252cb253d4bf786d4241d7a50a5e5..2d21c698e7edc696849052ffc828faa54387c241 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
@@ -26,8 +26,8 @@ import org.chromium.chrome.browser.compositor.Invalidator;
import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.omnibox.LocationBar;
import org.chromium.chrome.browser.util.ViewUtils;
-import org.chromium.chrome.browser.widget.SmoothProgressBar;
import org.chromium.chrome.browser.widget.TintedImageButton;
+import org.chromium.chrome.browser.widget.ToolbarProgressBar;
import org.chromium.ui.UiUtils;
/**
@@ -50,7 +50,7 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {
private ToolbarDataProvider mToolbarDataProvider;
private ToolbarTabController mToolbarTabController;
- private SmoothProgressBar mProgressBar;
+ private ToolbarProgressBar mProgressBar;
private boolean mNativeLibraryReady;
private boolean mUrlHasFocus;
@@ -74,12 +74,11 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {
protected void onFinishInflate() {
super.onFinishInflate();
- mProgressBar = (SmoothProgressBar) findViewById(R.id.progress);
+ mProgressBar = (ToolbarProgressBar) findViewById(R.id.progress);
if (mProgressBar != null) {
removeView(mProgressBar);
- Drawable progressDrawable = mProgressBar.getProgressDrawable();
getFrameLayoutParams(mProgressBar).topMargin = mToolbarHeightWithoutShadow
- - progressDrawable.getIntrinsicHeight();
+ - getFrameLayoutParams(mProgressBar).height;
}
mMenuButton = (TintedImageButton) findViewById(R.id.menu_button);
@@ -111,11 +110,6 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {
}
@Override
- public int getLoadProgress() {
- return 0;
- }
-
- @Override
public String getCorpusChipText() {
return null;
}
@@ -186,7 +180,7 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {
/**
* @return The {@link ProgressBar} this layout uses.
*/
- SmoothProgressBar getProgressBar() {
+ ToolbarProgressBar getProgressBar() {
return mProgressBar;
}
@@ -503,11 +497,33 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {
}
/**
+ * Starts load progress.
+ */
+ protected void startLoadProgress() {
+ if (mProgressBar != null) {
+ mProgressBar.start();
+ }
+ }
+
+ /**
* Sets load progress.
- * @param progress The load progress between 0 and 100.
+ * @param progress The load progress between 0 and 1.
*/
- protected void setLoadProgress(int progress) {
- if (mProgressBar != null) mProgressBar.setProgress(progress);
+ protected void setLoadProgress(float progress) {
+ if (mProgressBar != null) {
+ mProgressBar.setProgress(progress);
+ }
+ }
+
+ /**
+ * Finishes load progress.
+ * @param delayed Whether hiding progress bar should be delayed to give enough time for user to
+ * recognize the last state.
+ */
+ protected void finishLoadProgress(boolean delayed) {
+ if (mProgressBar != null) {
+ mProgressBar.finish(delayed);
+ }
}
/**

Powered by Google App Engine
This is Rietveld 408576698