fixes detection of SDK libraries

lib/src/codegen/js_module_item_order.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashMap;
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:dev_compiler/src/dependency_graph.dart' show corelibOrder;
 
 typedef void ModuleItemEmitter(AstNode item);
@@ skipping 164 matching lines @@
       // TODO(jmesserly): if we want to log what triggered laziness, this is
       // the place to do so.
       _loaded[current] = false;
     }
   }
 
   bool libraryIsLoaded(LibraryElement library) {
     assert(library != _currentLibrary);
 
     // The SDK is a special case: we optimize the order to prevent laziness.
-    if (library.isInSdk) {
+    if (_isDartUri(library)) {
       // SDK is loaded before non-SDK libraries
-      if (!_currentLibrary.isInSdk) return true;
+      if (!_isDartUri(_currentLibrary)) return true;
 
       // Compute the order of both SDK libraries. If unknown, assume it's after.
       var order = corelibOrder.indexOf(library.name);
       if (order == -1) order = corelibOrder.length;
 
       var currentOrder = corelibOrder.indexOf(_currentLibrary.name);
       if (currentOrder == -1) currentOrder = corelibOrder.length;
 
       // If the dart:* library we are currently compiling is loaded after the
       // class's library, then we know the class is available.
       if (order != currentOrder) return currentOrder > order;
 
       // If we don't know the order of the class's library or the current
       // library, do the normal cycle check. (Not all SDK libs are cycles.)
     }
 
     return !_inLibraryCycle(library);
   }
 
   /// Returns true if [library] depends on the [currentLibrary] via some
   /// transitive import.
   bool _inLibraryCycle(LibraryElement library) {
     // SDK libs don't depend on things outside the SDK.
     // (We can reach this via the recursive call below.)
-    if (library.isInSdk && !_currentLibrary.isInSdk) return false;
+    if (_isDartUri(library) && !_isDartUri(_currentLibrary)) return false;
 
     var result = _libraryCycleMemo[library];
     if (result != null) return result;
 
     result = library == _currentLibrary;
     _libraryCycleMemo[library] = result;
     for (var e in library.imports) {
       if (result) break;
       result = _inLibraryCycle(e.importedLibrary);
     }
     for (var e in library.exports) {
       if (result) break;
       result = _inLibraryCycle(e.exportedLibrary);
     }
     return _libraryCycleMemo[library] = result;
   }
+
+  /// Returns whether this is a library imported with 'dart:' URI.
+  ///
+  /// This is similar to [LibraryElement.isInSdk], but checking the URI instead
+  /// of the library naming convention, because the URI is reliable.
+  static bool _isDartUri(LibraryElement e) => e.source.uri.scheme == 'dart';

[vsm, 2015/06/10 16:41:15]

Do you want to assert e.isInSdk == _isDartUri(e)?  It looks like you also fixed
the names.

[Jennifer Messerly, 2015/06/10 16:46:04]

We can't assert it, because user can name their library "dart.my.awesome.lib".
Unless we intend to make that an error? Doesn't seem worth it to me.

 }