fixes detection of SDK libraries

lib/devc.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Command line tool to run the checker on a Dart program.
 library dev_compiler.devc;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
@@ skipping 137 matching lines @@
     if (_entryNode is DartSourceNode) return _entryNode == node;
     return (_entryNode as HtmlSourceNode).scripts.contains(node);
   }
 
   void _buildDartLibrary(DartSourceNode node) {
     var source = node.source;
     // TODO(sigmund): find out from analyzer team if there is a better way
     context.applyChanges(new ChangeSet()..changedSource(source));
     var entryUnit = context.resolveCompilationUnit2(source, source);
     var lib = entryUnit.element.enclosingElement;
-    if (!options.checkSdk && lib.isInSdk) return;
+    if (!options.checkSdk && lib.source.uri.scheme == 'dart') return;

[vsm, 2015/06/10 16:41:15]

Move _isDartUri to utils and call that instead?

[Jennifer Messerly, 2015/06/10 16:46:04]

funny, almost did that. The thing is, now it becomes an opaque call, and instead
of a simple isInSdk, you have to import 'utils.dart' just do a URI scheme check.
Overall, I'd prefer to keep it as is ... it's kind of my informal rule of
"straightforward check of a single property" that should be inlined.

(Contrast with isInlineJS, that needs to check 3 things, two of them unrelated)

     var current = node.info;
     if (current != null) {
       assert(current.library == lib);
     } else {
       node.info = current = new LibraryInfo(lib, _isEntry(node));
     }
     _reporter.enterLibrary(source.uri);
     _libraries.add(current);
     rules.currentLibraryInfo = current;
 
@@ skipping 150 matching lines @@
       // Note: the cache-control header should be enough, but this doesn't hurt
       // and can help renew the policy after it expires.
       headers['ETag'] = hash;
     }
     return response.change(headers: headers);
   };
 }
 
 final _log = new Logger('dev_compiler');
 final _earlyErrorResult = new CheckerResults(const [], null, true);