vs2015: avoid warning in media/filters/vp8_bool_decoder_unittest.cc

vs2015: avoid warning in media/filters/vp8_bool_decoder_unittest.cc

FAILED: ninja -t msvc -e environment.x86 -- "C:\b\depot_tools\win_toolchain\vs_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\media\filters\media_unittests.vp8_bool_decoder_unittest.obj.rsp /c ..\..\media\filters\vp8_bool_decoder_unittest.cc /Foobj\media\filters\media_unittests.vp8_bool_decoder_unittest.obj /Fdobj\media\media_unittests.cc.pdb
c:\b\build\slave\chromium-rel-builder\build\src\media\filters\vp8_bool_decoder_unittest.cc(113): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\chromium-rel-builder\build\src\media\filters\vp8_bool_decoder_unittest.cc(113): warning C4267: 'argument': conversion from 'size_t' to 'uint8_t', possible loss of data

R=wolenetz@chromium.org
BUG=440500
Committed: https://crrev.com/a4526b6543681775d9f28850cba970809d6f893a
Cr-Commit-Position: refs/heads/master@{#333502}

[scottmg, 2015-06-08 20:48:02]

scottmg@chromium.org changed reviewers:
+ wolenetz@chromium.org

[scottmg, 2015-06-08 22:46:15]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-08 22:46:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1170763003/1

[commit-bot: I haz the power, 2015-06-08 23:07:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-08 23:08:00]

Dry run: This issue passed the CQ dry run.

[wolenetz, 2015-06-08 23:57:06]

lgtm % nit

https://codereview.chromium.org/1170763003/diff/1/media/filters/vp8_bool_deco...
File media/filters/vp8_bool_decoder_unittest.cc (right):

https://codereview.chromium.org/1170763003/diff/1/media/filters/vp8_bool_deco...
media/filters/vp8_bool_decoder_unittest.cc:113: ASSERT_TRUE(bd_.ReadBool(&out,
static_cast<uint8_t>(i)));
nit: maybe also add some assertion that (NUM_BITS_TO_TEST - 1) fits within the
range of uint8_t ? This is simply in case NUM_BITS_TO_TEST ever becomes
larger... wdyt?

[scottmg, 2015-06-09 16:08:31]

Patchset #2 (id:20001) has been deleted

[scottmg, 2015-06-09 16:09:37]

https://codereview.chromium.org/1170763003/diff/1/media/filters/vp8_bool_deco...
File media/filters/vp8_bool_decoder_unittest.cc (right):

https://codereview.chromium.org/1170763003/diff/1/media/filters/vp8_bool_deco...
media/filters/vp8_bool_decoder_unittest.cc:113: ASSERT_TRUE(bd_.ReadBool(&out,
static_cast<uint8_t>(i)));
On 2015/06/08 23:57:06, wolenetz wrote:
> nit: maybe also add some assertion that (NUM_BITS_TO_TEST - 1) fits within the
> range of uint8_t ? This is simply in case NUM_BITS_TO_TEST ever becomes
> larger... wdyt?

Done.

[scottmg, 2015-06-09 16:09:40]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2015-06-09 16:09:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
wolenetz@chromium.org
Link to the patchset: https://codereview.chromium.org/1170763003/#ps40001
(title: "range assertion")

[commit-bot: I haz the power, 2015-06-09 16:10:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1170763003/40001

[commit-bot: I haz the power, 2015-06-09 16:27:43]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-06-09 16:29:37]

Patchset 2 (id:??) landed as
https://crrev.com/a4526b6543681775d9f28850cba970809d6f893a
Cr-Commit-Position: refs/heads/master@{#333502}