Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 117073002: Reland "Refactor audio manager for Android to avoid heavy tasks at startup" (Closed)

Created:
7 years ago by henrika (OOO until Aug 14)
Modified:
7 years ago
CC:
chromium-reviews, craigdh+watch_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Reland "Refactor audio manager for Android to avoid heavy tasks at startup" Original CL: https://codereview.chromium.org/110173003/. Refactor audio manager for Android to avoid heavy tasks at startup. Main goal of this CL is to avoid all demanding tasks (e.g. initiate audio routing, detect BT devices etc.) at Chrome startup. All we do now is to populate the list of available devices. BT support has been removed but will be added in an upcoming CL. NOTRY=True TBR=bulach, tommi BUG=324464 TEST=media_unittests --gtest-filter=AudioAndroid* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -240 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/android/audio_android_unittest.cc View 2 chunks +53 lines, -0 lines 0 comments Download
M media/audio/android/audio_manager_android.h View 1 chunk +3 lines, -2 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 7 chunks +40 lines, -16 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java View 21 chunks +210 lines, -220 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/117073002/1
7 years ago (2013-12-17 08:54:14 UTC) #1
henrika (OOO until Aug 14)
7 years ago (2013-12-17 08:54:49 UTC) #2
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years ago (2013-12-17 09:46:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/117073002/1
7 years ago (2013-12-17 09:47:13 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-17 09:47:24 UTC) #5
Message was sent while issue was closed.
Change committed as 241247

Powered by Google App Engine
This is Rietveld 408576698