Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: Source/core/dom/Touch.idl

Issue 1170703003: Touch.identifier should be long, not unsigned long (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updating as per review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2008, The Android Open Source Project 2 * Copyright 2008, The Android Open Source Project
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * * Redistributions of source code must retain the above copyright 7 * * Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * * Redistributions in binary form must reproduce the above copyright 9 * * Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 10 matching lines...) Expand all
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 // http://rawgit.com/w3c/touch-events/v1-errata/touchevents.html#touch-interface 26 // http://rawgit.com/w3c/touch-events/v1-errata/touchevents.html#touch-interface
27 27
28 [ 28 [
29 WillBeGarbageCollected, 29 WillBeGarbageCollected,
30 ] interface Touch { 30 ] interface Touch {
31 // FIXME: identifier should be long, not unsigned long. 31 readonly attribute long identifier;
32 readonly attribute unsigned long identifier;
33 readonly attribute EventTarget target; 32 readonly attribute EventTarget target;
34 readonly attribute double screenX; 33 readonly attribute double screenX;
35 readonly attribute double screenY; 34 readonly attribute double screenY;
36 readonly attribute double clientX; 35 readonly attribute double clientX;
37 readonly attribute double clientY; 36 readonly attribute double clientY;
38 readonly attribute double pageX; 37 readonly attribute double pageX;
39 readonly attribute double pageY; 38 readonly attribute double pageY;
40 39
41 // Touch Events Extensions 40 // Touch Events Extensions
42 // http://rawgit.com/w3c/touch-events/master/touchevents.html#touch-interfac e 41 // http://rawgit.com/w3c/touch-events/master/touchevents.html#touch-interfac e
43 readonly attribute float radiusX; 42 readonly attribute float radiusX;
44 readonly attribute float radiusY; 43 readonly attribute float radiusY;
45 readonly attribute float rotationAngle; 44 readonly attribute float rotationAngle;
46 readonly attribute float force; 45 readonly attribute float force;
47 46
48 // Non-standard APIs 47 // Non-standard APIs
49 [DeprecateAs=PrefixedTouchRadiusX, ImplementedAs=radiusX] readonly attribute float webkitRadiusX; 48 [DeprecateAs=PrefixedTouchRadiusX, ImplementedAs=radiusX] readonly attribute float webkitRadiusX;
50 [DeprecateAs=PrefixedTouchRadiusY, ImplementedAs=radiusY] readonly attribute float webkitRadiusY; 49 [DeprecateAs=PrefixedTouchRadiusY, ImplementedAs=radiusY] readonly attribute float webkitRadiusY;
51 [DeprecateAs=PrefixedTouchRotationAngle, ImplementedAs=rotationAngle] readon ly attribute float webkitRotationAngle; 50 [DeprecateAs=PrefixedTouchRotationAngle, ImplementedAs=rotationAngle] readon ly attribute float webkitRotationAngle;
52 [DeprecateAs=PrefixedTouchForce, ImplementedAs=force] readonly attribute flo at webkitForce; 51 [DeprecateAs=PrefixedTouchForce, ImplementedAs=force] readonly attribute flo at webkitForce;
53 }; 52 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698