Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(75)

Issue 1170703002: Import more CSS Writing Modes Level 3 test suites (Closed)

Created:
4 years, 10 months ago by kojii
Modified:
4 years, 10 months ago
Reviewers:
tkent, Dirk Pranke, jsbell, joelo
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Import more CSS Writing Modes Level 3 test suites * Analyzed causes of skipped tests and reduced. * Some "1px diff" failures were fixed in upstream, removed ImageOnlyFailure. * Changed from Timeout to Slow: imported/csswg-test/css-writing-modes-3/text-orientation-script-001?.html * Skip reference files recognized as tests: imported/csswg-test/css-writing-modes-3/text-combine-upright/reference update-w3c-deps import using blink 7d551bb67f66671e9fb5bb0df2dccb67fc973fc3: imported csswg-test@56549e36b3229a0ca986b7de33f3b1011cea52f6 imported web-platform-tests@5dcd874062e0ed0f6a68c05e45df182f8e7a7a28 BUG=492664 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196648

Patch Set 1 #

Patch Set 2 : TestExpetations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+841 lines, -690 lines) Patch
M LayoutTests/SlowTests View 1 chunk +17 lines, -0 lines 0 comments Download
M LayoutTests/TestExpectations View 1 4 chunks +41 lines, -28 lines 0 comments Download
M LayoutTests/W3CImportExpectations View 3 chunks +4 lines, -25 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/block-flow-direction-009.xht View 3 chunks +7 lines, -6 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/block-flow-direction-009-expected.xht View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/imported/csswg-test/css-writing-modes-3/box-offsets-rel-pos-vlr-005.xht View 1 chunk +173 lines, -0 lines 0 comments Download
A LayoutTests/imported/csswg-test/css-writing-modes-3/box-offsets-rel-pos-vlr-005-expected.xht View 1 chunk +90 lines, -0 lines 0 comments Download
A LayoutTests/imported/csswg-test/css-writing-modes-3/box-offsets-rel-pos-vrl-004.xht View 1 chunk +173 lines, -0 lines 0 comments Download
A LayoutTests/imported/csswg-test/css-writing-modes-3/box-offsets-rel-pos-vrl-004-expected.xht View 1 chunk +97 lines, -0 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vlr-003.xht View 1 chunk +4 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vlr-003-expected.xht View 1 chunk +6 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vlr-005.xht View 1 chunk +4 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vlr-005-expected.xht View 1 chunk +9 lines, -5 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vlr-007.xht View 1 chunk +4 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vlr-007-expected.xht View 1 chunk +9 lines, -5 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vlr-009.xht View 1 chunk +4 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vlr-009-expected.xht View 1 chunk +10 lines, -5 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vrl-002.xht View 1 chunk +4 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vrl-002-expected.xht View 1 chunk +6 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vrl-004.xht View 1 chunk +4 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vrl-004-expected.xht View 1 chunk +9 lines, -5 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vrl-006.xht View 1 chunk +4 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vrl-006-expected.xht View 1 chunk +9 lines, -5 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vrl-008.xht View 1 chunk +4 lines, -8 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/clip-rect-vrl-008-expected.xht View 1 chunk +10 lines, -5 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/line-box-direction-009.xht View 2 chunks +4 lines, -3 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/line-box-direction-009-expected.xht View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/full-width-horizontal-notref.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/full-width-horizontal-notref-expected.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/full-width-notcu-notref.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/full-width-notcu-notref-expected.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/full-width-ref.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/full-width-ref-expected.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/text-emphasis-001-ref.htm View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/vertical-ahem-1x1-ref.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/vertical-ahem-1x1-ref-expected.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/vertical-ahem-1x3-ref.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/vertical-ahem-1x3-ref-expected.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/vertical-ahem-1x4-ref.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/vertical-ahem-1x4-ref-expected.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/vertical-ahem-1x5-ref.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/reference/vertical-ahem-1x5-ref-expected.html View 1 chunk +0 lines, -25 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/value-all-002.html View 3 chunks +7 lines, -7 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/value-all-002-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/value-all-003.html View 3 chunks +7 lines, -7 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright/value-all-003-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-001.xht View 2 chunks +14 lines, -14 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-001-expected.xht View 1 chunk +11 lines, -11 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-004.xht View 2 chunks +14 lines, -14 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-004-expected.xht View 1 chunk +11 lines, -11 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-007.xht View 2 chunks +14 lines, -14 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-007-expected.xht View 1 chunk +11 lines, -11 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-010.xht View 2 chunks +14 lines, -14 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-010-expected.xht View 1 chunk +11 lines, -11 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-019.xht View 2 chunks +14 lines, -14 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/vertical-alignment-019-expected.xht View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kojii
PTAL. It's getting stabilized and I hope this isn't as complicated as recent a few ...
4 years, 10 months ago (2015-06-08 04:37:18 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-08 04:47:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170703002/20001
4 years, 10 months ago (2015-06-08 04:50:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196648
4 years, 10 months ago (2015-06-08 04:53:25 UTC) #6
joelo
4 years, 10 months ago (2015-06-08 04:58:17 UTC) #8
Message was sent while issue was closed.
lgtm, thanks again!

Powered by Google App Engine
This is Rietveld 408576698