Issue 1170633002: Refactor manage.py to be more readable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1170633002: Refactor manage.py to be more readable. (Closed)

Created:
5 years, 6 months ago by M-A Ruel

Modified:
5 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2_manage

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Refactor manage.py to be more readable. Split the behaviors into functions instead of a gigantic main(). R=dpranke@chromium.org BUG=98637 Committed: https://crrev.com/403f2058371962ecff1f7d66cacf556d2a86cbe6 Cr-Commit-Position: refs/heads/master@{#333165}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -111 lines)			Patch
	M	testing/buildbot/manage.py	View		3 chunks	+149 lines, -111 lines	0 comments	Download

Total messages: 6 (1 generated)

Dirk Pranke

lgtm. more extensive than I was asking for, but looks fine :).

5 years, 6 months ago (2015-06-05 21:25:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170633002/1

5 years, 6 months ago (2015-06-05 22:01:44 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 23:08:52 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/403f2058371962ecff1f7d66cacf556d2a86cbe6
Cr-Commit-Position: refs/heads/master@{#333165}