IDL compiler: [RaisesException] interface type attribute

Source/bindings/scripts/unstable/v8_attributes.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 122 matching lines @@
 
 # Getter
 
 def generate_getter(interface, attribute, contents):
     idl_type = attribute.idl_type
     extended_attributes = attribute.extended_attributes
 
     cpp_value = getter_expression(interface, attribute, contents)
     # Normally we can inline the function call into the return statement to
     # avoid the overhead of using a Ref<> temporary, but for some cases
-    # (nullable types, EventHandler, [CachedAttribute], or if there are
-    # exceptions), we need to use a local variable.
+    # (nullable types, [RaisesException], [CachedAttribute], and EventHandler)
+    # we need to use a local variable.
     # FIXME: check if compilers are smart enough to inline this, and if so,
     # always use a local variable (for readability and CG simplicity).
-    if (attribute.is_nullable or
-        idl_type == 'EventHandler' or
-        'CachedAttribute' in extended_attributes or
-        contents['is_getter_raises_exception']):
+    if idl_type == 'EventHandler':
         contents['cpp_value_original'] = cpp_value
-        cpp_value = 'jsValue'
+        cpp_rvalue = cpp_value = 'jsValue'
+    elif (attribute.is_nullable or
+          contents['is_getter_raises_exception'] or
+          'CachedAttribute' in extended_attributes):
+        contents['cpp_value_original'] = cpp_value
+        cpp_rvalue = cpp_value = 'jsValue'
+        if v8_types.is_interface_type(idl_type):
+            cpp_rvalue += '.release()'
+    else:
+        cpp_rvalue = cpp_value
 
     if contents['is_keep_alive_for_gc']:
         v8_set_return_value_statement = 'v8SetReturnValue(info, wrapper)'
         includes.add('bindings/v8/V8HiddenPropertyName.h')
     else:
-        v8_set_return_value_statement = v8_types.v8_set_return_value(idl_type, cpp_value, extended_attributes=extended_attributes, script_wrappable='imp')
+        v8_set_return_value_statement = v8_types.v8_set_return_value(idl_type, cpp_rvalue, extended_attributes=extended_attributes, script_wrappable='imp')
 
     contents.update({
         'cpp_value': cpp_value,
         'v8_set_return_value': v8_set_return_value_statement,
     })
 
 
 def getter_expression(interface, attribute, contents):
     arguments = []
     this_getter_base_name = getter_base_name(attribute, arguments)
@@ skipping 153 matching lines @@
         property_attributes_list.append('v8::DontEnum')
     if 'Unforgeable' in extended_attributes:
         property_attributes_list.append('v8::DontDelete')
     return property_attributes_list or ['v8::None']
 
 
 # Constructors
 
 def is_constructor_attribute(attribute):
     return attribute.idl_type.endswith('Constructor')