Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: content/browser/loader/upload_data_stream_builder_unittest.cc

Issue 1170623003: Revert "content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/upload_data_stream_builder_unittest.cc
diff --git a/content/browser/loader/upload_data_stream_builder_unittest.cc b/content/browser/loader/upload_data_stream_builder_unittest.cc
index 174a89bff0d43928cc57c42cced202d5cca5ab94..57161eaf4caf1a281d91b2c5fd020e2c192f5f39 100644
--- a/content/browser/loader/upload_data_stream_builder_unittest.cc
+++ b/content/browser/loader/upload_data_stream_builder_unittest.cc
@@ -9,8 +9,9 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
+#include "base/message_loop/message_loop.h"
+#include "base/message_loop/message_loop_proxy.h"
#include "base/run_loop.h"
-#include "base/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "content/common/resource_request_body.h"
#include "net/base/io_buffer.h"
@@ -77,8 +78,7 @@ TEST(UploadDataStreamBuilderTest, CreateUploadDataStreamWithoutBlob) {
request_body->set_identifier(kIdentifier);
scoped_ptr<net::UploadDataStream> upload(UploadDataStreamBuilder::Build(
- request_body.get(), NULL, NULL,
- base::ThreadTaskRunnerHandle::Get().get()));
+ request_body.get(), NULL, NULL, base::MessageLoopProxy::current().get()));
EXPECT_EQ(kIdentifier, upload->identifier());
ASSERT_TRUE(upload->GetElementReaders());
@@ -146,9 +146,12 @@ TEST(UploadDataStreamBuilderTest, ResolveBlobAndCreateUploadDataStream) {
upload_element2.length(),
upload_element2.expected_modification_time());
- scoped_ptr<net::UploadDataStream> upload(UploadDataStreamBuilder::Build(
- request_body.get(), &blob_storage_context, NULL,
- base::ThreadTaskRunnerHandle::Get().get()));
+ scoped_ptr<net::UploadDataStream> upload(
+ UploadDataStreamBuilder::Build(
+ request_body.get(),
+ &blob_storage_context,
+ NULL,
+ base::MessageLoopProxy::current().get()));
ASSERT_TRUE(upload->GetElementReaders());
ASSERT_EQ(2U, upload->GetElementReaders()->size());
@@ -162,8 +165,10 @@ TEST(UploadDataStreamBuilderTest, ResolveBlobAndCreateUploadDataStream) {
request_body->AppendBlob(blob_id0);
upload = UploadDataStreamBuilder::Build(
- request_body.get(), &blob_storage_context, NULL,
- base::ThreadTaskRunnerHandle::Get().get());
+ request_body.get(),
+ &blob_storage_context,
+ NULL,
+ base::MessageLoopProxy::current().get());
ASSERT_TRUE(upload->GetElementReaders());
ASSERT_EQ(0U, upload->GetElementReaders()->size());
@@ -172,8 +177,10 @@ TEST(UploadDataStreamBuilderTest, ResolveBlobAndCreateUploadDataStream) {
request_body->AppendBlob(blob_id1);
upload = UploadDataStreamBuilder::Build(
- request_body.get(), &blob_storage_context, NULL,
- base::ThreadTaskRunnerHandle::Get().get());
+ request_body.get(),
+ &blob_storage_context,
+ NULL,
+ base::MessageLoopProxy::current().get());
ASSERT_TRUE(upload->GetElementReaders());
ASSERT_EQ(2U, upload->GetElementReaders()->size());
EXPECT_TRUE(AreElementsEqual(
@@ -194,8 +201,10 @@ TEST(UploadDataStreamBuilderTest, ResolveBlobAndCreateUploadDataStream) {
upload_element2.expected_modification_time());
upload = UploadDataStreamBuilder::Build(
- request_body.get(), &blob_storage_context, NULL,
- base::ThreadTaskRunnerHandle::Get().get());
+ request_body.get(),
+ &blob_storage_context,
+ NULL,
+ base::MessageLoopProxy::current().get());
ASSERT_TRUE(upload->GetElementReaders());
ASSERT_EQ(4U, upload->GetElementReaders()->size());
EXPECT_TRUE(AreElementsEqual(
@@ -219,9 +228,11 @@ TEST(UploadDataStreamBuilderTest, ResolveBlobAndCreateUploadDataStream) {
upload_element2.expected_modification_time());
request_body->AppendBlob(blob_id1);
- upload = UploadDataStreamBuilder::Build(
- request_body.get(), &blob_storage_context, NULL,
- base::ThreadTaskRunnerHandle::Get().get());
+ upload =
+ UploadDataStreamBuilder::Build(request_body.get(),
+ &blob_storage_context,
+ NULL,
+ base::MessageLoopProxy::current().get());
ASSERT_TRUE(upload->GetElementReaders());
ASSERT_EQ(4U, upload->GetElementReaders()->size());
EXPECT_TRUE(AreElementsEqual(
@@ -246,8 +257,10 @@ TEST(UploadDataStreamBuilderTest, ResolveBlobAndCreateUploadDataStream) {
upload_element2.expected_modification_time());
upload = UploadDataStreamBuilder::Build(
- request_body.get(), &blob_storage_context, NULL,
- base::ThreadTaskRunnerHandle::Get().get());
+ request_body.get(),
+ &blob_storage_context,
+ NULL,
+ base::MessageLoopProxy::current().get());
ASSERT_TRUE(upload->GetElementReaders());
ASSERT_EQ(4U, upload->GetElementReaders()->size());
EXPECT_TRUE(AreElementsEqual(
@@ -274,8 +287,10 @@ TEST(UploadDataStreamBuilderTest, ResolveBlobAndCreateUploadDataStream) {
upload_element2.expected_modification_time());
upload = UploadDataStreamBuilder::Build(
- request_body.get(), &blob_storage_context, NULL,
- base::ThreadTaskRunnerHandle::Get().get());
+ request_body.get(),
+ &blob_storage_context,
+ NULL,
+ base::MessageLoopProxy::current().get());
ASSERT_TRUE(upload->GetElementReaders());
ASSERT_EQ(8U, upload->GetElementReaders()->size());
EXPECT_TRUE(AreElementsEqual(
@@ -326,7 +341,7 @@ TEST(UploadDataStreamBuilderTest,
scoped_refptr<ResourceRequestBody> request_body(new ResourceRequestBody());
scoped_ptr<net::UploadDataStream> upload(UploadDataStreamBuilder::Build(
request_body.get(), &blob_storage_context, NULL,
- base::ThreadTaskRunnerHandle::Get().get()));
+ base::MessageLoopProxy::current().get()));
request_body = new ResourceRequestBody();
request_body->AppendBlob(blob_id);
@@ -335,7 +350,7 @@ TEST(UploadDataStreamBuilderTest,
upload = UploadDataStreamBuilder::Build(
request_body.get(), &blob_storage_context, NULL,
- base::ThreadTaskRunnerHandle::Get().get());
+ base::MessageLoopProxy::current().get());
ASSERT_TRUE(upload->GetElementReaders());
const auto& readers = *upload->GetElementReaders();
ASSERT_EQ(3U, readers.size());
« no previous file with comments | « content/browser/loader/resource_loader_unittest.cc ('k') | content/browser/media/capture/content_video_capture_device_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698