content/browser/cache_storage/cache_storage_cache.cc - Issue 1170623003: Revert "content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/cache_storage/cache_storage_cache.cc

Issue 1170623003: Revert "content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/cache_storage/cache_storage.cc ('k') | content/browser/cache_storage/cache_storage_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/cache_storage/cache_storage_cache.cc

diff --git a/content/browser/cache_storage/cache_storage_cache.cc b/content/browser/cache_storage/cache_storage_cache.cc

index ab57e308e7ed83047e758a4eefee852f8827f2ce..279dfc3d8663dc7a602cfba62935048ff105fff9 100644

--- a/content/browser/cache_storage/cache_storage_cache.cc

+++ b/content/browser/cache_storage/cache_storage_cache.cc

@@ -9,6 +9,7 @@

#include "base/barrier_closure.h"

#include "base/files/file_path.h"

#include "base/guid.h"

+#include "base/message_loop/message_loop_proxy.h"

#include "base/metrics/histogram_macros.h"

#include "base/strings/string_util.h"

#include "content/browser/cache_storage/cache_storage.pb.h"

@@ -1179,7 +1180,7 @@ void CacheStorageCache::CreateBackend(const ErrorCallback& callback) {

weak_ptr_factory_.GetWeakPtr(), callback,

base::Passed(backend_ptr.Pass()));

- // TODO(jkarlin): Use the cache task runner that ServiceWorkerCacheCore

+ // TODO(jkarlin): Use the cache MessageLoopProxy that ServiceWorkerCacheCore

// has for disk caches.

int rv = disk_cache::CreateCacheBackend(

cache_type, net::CACHE_BACKEND_SIMPLE, path_, kMaxCacheBytes,

« no previous file with comments | « content/browser/cache_storage/cache_storage.cc ('k') | content/browser/cache_storage/cache_storage_cache_unittest.cc » ('j') | no next file with comments »