Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: content/browser/shareable_file_reference_unittest.cc

Issue 1170623003: Revert "content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "storage/browser/blob/shareable_file_reference.h" 5 #include "storage/browser/blob/shareable_file_reference.h"
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/message_loop/message_loop_proxy.h"
9 #include "base/run_loop.h" 10 #include "base/run_loop.h"
10 #include "base/single_thread_task_runner.h"
11 #include "base/thread_task_runner_handle.h"
12 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
13 12
14 using storage::ShareableFileReference; 13 using storage::ShareableFileReference;
15 14
16 namespace content { 15 namespace content {
17 16
18 TEST(ShareableFileReferenceTest, TestReferences) { 17 TEST(ShareableFileReferenceTest, TestReferences) {
19 base::MessageLoop message_loop; 18 base::MessageLoop message_loop;
20 scoped_refptr<base::SingleThreadTaskRunner> task_runner = 19 scoped_refptr<base::MessageLoopProxy> loop_proxy =
21 base::ThreadTaskRunnerHandle::Get(); 20 base::MessageLoopProxy::current();
22 base::ScopedTempDir temp_dir; 21 base::ScopedTempDir temp_dir;
23 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 22 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
24 23
25 // Create a file. 24 // Create a file.
26 base::FilePath file; 25 base::FilePath file;
27 base::CreateTemporaryFileInDir(temp_dir.path(), &file); 26 base::CreateTemporaryFileInDir(temp_dir.path(), &file);
28 EXPECT_TRUE(base::PathExists(file)); 27 EXPECT_TRUE(base::PathExists(file));
29 28
30 // Create a first reference to that file. 29 // Create a first reference to that file.
31 scoped_refptr<ShareableFileReference> reference1; 30 scoped_refptr<ShareableFileReference> reference1;
32 reference1 = ShareableFileReference::Get(file); 31 reference1 = ShareableFileReference::Get(file);
33 EXPECT_FALSE(reference1.get()); 32 EXPECT_FALSE(reference1.get());
34 reference1 = ShareableFileReference::GetOrCreate( 33 reference1 = ShareableFileReference::GetOrCreate(
35 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, task_runner.get()); 34 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy.get());
36 EXPECT_TRUE(reference1.get()); 35 EXPECT_TRUE(reference1.get());
37 EXPECT_TRUE(file == reference1->path()); 36 EXPECT_TRUE(file == reference1->path());
38 37
39 // Get a second reference to that file. 38 // Get a second reference to that file.
40 scoped_refptr<ShareableFileReference> reference2; 39 scoped_refptr<ShareableFileReference> reference2;
41 reference2 = ShareableFileReference::Get(file); 40 reference2 = ShareableFileReference::Get(file);
42 EXPECT_EQ(reference1.get(), reference2.get()); 41 EXPECT_EQ(reference1.get(), reference2.get());
43 reference2 = ShareableFileReference::GetOrCreate( 42 reference2 = ShareableFileReference::GetOrCreate(
44 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, task_runner.get()); 43 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy.get());
45 EXPECT_EQ(reference1.get(), reference2.get()); 44 EXPECT_EQ(reference1.get(), reference2.get());
46 45
47 // Drop the first reference, the file and reference should still be there. 46 // Drop the first reference, the file and reference should still be there.
48 reference1 = NULL; 47 reference1 = NULL;
49 EXPECT_TRUE(ShareableFileReference::Get(file).get()); 48 EXPECT_TRUE(ShareableFileReference::Get(file).get());
50 base::RunLoop().RunUntilIdle(); 49 base::RunLoop().RunUntilIdle();
51 EXPECT_TRUE(base::PathExists(file)); 50 EXPECT_TRUE(base::PathExists(file));
52 51
53 // Drop the second reference, the file and reference should get deleted. 52 // Drop the second reference, the file and reference should get deleted.
54 reference2 = NULL; 53 reference2 = NULL;
55 EXPECT_FALSE(ShareableFileReference::Get(file).get()); 54 EXPECT_FALSE(ShareableFileReference::Get(file).get());
56 base::RunLoop().RunUntilIdle(); 55 base::RunLoop().RunUntilIdle();
57 EXPECT_FALSE(base::PathExists(file)); 56 EXPECT_FALSE(base::PathExists(file));
58 57
59 // TODO(michaeln): add a test for files that aren't deletable behavior. 58 // TODO(michaeln): add a test for files that aren't deletable behavior.
60 } 59 }
61 60
62 } // namespace content 61 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698