Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1170623002: Add some deterministic build trybots (Closed)

Created:
5 years, 6 months ago by Sébastien Marchand
Modified:
5 years, 6 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add some deterministic build trybots BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295542

Patch Set 1 #

Total comments: 9

Patch Set 2 : Address M-A's comments. #

Patch Set 3 : Add the test expectation files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M masters/master.tryserver.chromium.linux/master.cfg View 1 3 chunks +11 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium.linux/slaves.cfg View 2 chunks +2 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium.mac/master.cfg View 1 1 chunk +5 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium.mac/slaves.cfg View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.tryserver.chromium.win/master.cfg View 1 1 chunk +6 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium.win/slaves.cfg View 1 chunk +1 line, -0 lines 0 comments Download
A + scripts/slave/recipes/deterministic_build.py View 1 2 4 chunks +10 lines, -7 lines 0 comments Download
A + scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_Android_deterministic_build.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_Linux_deterministic_build.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_Mac_deterministic_build.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_build.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_Windows_deterministic_build.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_android_deterministic.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_linux_deterministic.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_mac_deterministic.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_windows_deterministic.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sébastien Marchand
PTAL. The script to generate the recipe's expectation files seems to be broken on Windows, ...
5 years, 6 months ago (2015-06-05 17:20:27 UTC) #2
M-A Ruel
lgtm with small changes. Thanks! https://codereview.chromium.org/1170623002/diff/1/masters/master.tryserver.chromium.linux/master.cfg File masters/master.tryserver.chromium.linux/master.cfg (right): https://codereview.chromium.org/1170623002/diff/1/masters/master.tryserver.chromium.linux/master.cfg#newcode101 masters/master.tryserver.chromium.linux/master.cfg:101: 'slavebuilddir': 'android_deterministic' It's not ...
5 years, 6 months ago (2015-06-05 17:26:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170623002/40001
5 years, 6 months ago (2015-06-05 18:15:42 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295542
5 years, 6 months ago (2015-06-05 18:22:04 UTC) #7
Sébastien Marchand
Yeah ! We need to restart the masters now, should we wait for https://codereview.chromium.org/1147043007/ ? ...
5 years, 6 months ago (2015-06-05 18:26:45 UTC) #8
M-A Ruel
5 years, 6 months ago (2015-06-05 18:29:19 UTC) #9
Message was sent while issue was closed.
On 2015/06/05 18:26:45, Sébastien Marchand wrote:
> Yeah ! We need to restart the masters now, should we wait for
> https://codereview.chromium.org/1147043007/ ?

Plan:
- Restart the try server masters.
- Make sure the new builders work.
- Commit https://codereview.chromium.org/1147043007
- Restarts CI masters.
- Send PSA.

Powered by Google App Engine
This is Rietveld 408576698