Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: Source/core/html/HTMLAudioElement.cpp

Issue 1170583002: Recalc style or reattach when adding or removing the audio controls attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLAudioElement.h ('k') | Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 { 50 {
51 RefPtrWillBeRawPtr<HTMLAudioElement> audio = adoptRefWillBeNoop(new HTMLAudi oElement(document)); 51 RefPtrWillBeRawPtr<HTMLAudioElement> audio = adoptRefWillBeNoop(new HTMLAudi oElement(document));
52 audio->ensureUserAgentShadowRoot(); 52 audio->ensureUserAgentShadowRoot();
53 audio->setPreload(AtomicString("auto", AtomicString::ConstructFromLiteral)); 53 audio->setPreload(AtomicString("auto", AtomicString::ConstructFromLiteral));
54 if (!src.isNull()) 54 if (!src.isNull())
55 audio->setSrc(src); 55 audio->setSrc(src);
56 audio->suspendIfNeeded(); 56 audio->suspendIfNeeded();
57 return audio.release(); 57 return audio.release();
58 } 58 }
59 59
60 bool HTMLAudioElement::layoutObjectIsNeeded(const ComputedStyle& style)
61 {
62 return shouldShowControls() && HTMLMediaElement::layoutObjectIsNeeded(style) ;
60 } 63 }
64
65 void HTMLAudioElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value)
66 {
67 if (name == controlsAttr) {
68 if (value.isNull())
69 lazyReattachIfAttached();
70 else
71 setNeedsStyleRecalc(LocalStyleChange, StyleChangeReasonForTracing::f romAttribute(name));
72 }
73
74 HTMLMediaElement::parseAttribute(name, value);
75 }
76
77 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLAudioElement.h ('k') | Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698