Apply coverage in XP base class when using dst reads

src/gpu/gl/GrGLXferProcessor.h

Index: src/gpu/gl/GrGLXferProcessor.h
diff --git a/src/gpu/gl/GrGLXferProcessor.h b/src/gpu/gl/GrGLXferProcessor.h
index 6b05dcb37d6b653c76144c5e9b2336bc404ae5fe..265eb9fe7e86b5880be25afe9c2f32bf0cac744e 100644
--- a/src/gpu/gl/GrGLXferProcessor.h
+++ b/src/gpu/gl/GrGLXferProcessor.h
@@ -59,7 +59,22 @@ public:
     void setData(const GrGLProgramDataManager& pdm, const GrXferProcessor& xp);
 
 private:
-    virtual void onEmitCode(const EmitArgs&) = 0;
+    /**
+     * Called by emitCode() when the XP will not be performing a dst read. This method is
+     * responsible for both blending and coverage. A subclass only needs to implement this method if
+     * it can construct a GrXferProcessor that will not read the dst color.
+     */
+    virtual void onEmitCode(const EmitArgs&) { SkFAIL("onEmitCode not implemented."); }

[egdaniel, 2015/06/05 16:44:01]

So some pretty unhelpful feed back here...but something about the naming now of
onEmitCode and onEmitShaderBlend doesn't really shout out what these functions
do and when/what a subclass needs to implement for each. Maybe drop the on and
have them be emitShaderBlendCode and emitFixedFunctionBlendCode. Sorry not too
helpful on good names.

[Chris Dalton, 2015/06/05 17:41:36]

I've thought about it some and have come up with some more semi-good names :)

For the first I still wonder if "onEmitCode" might be ok? It would be consistent
with onGetBlendInfo and onHasSecondaryOutput, where it's the full implementation
of that function in the subclass, just only called when not doing a dst read.

For the second, I've so far come up with "emitBlendCodeForDstRead".

Thoughts?

+
+    /**
+     * Called by emitCode() when the XP will perform a dst read. This method only needs to supply
+     * the blending logic. The base class applies coverage. A subclass only needs to implement this
+     * method if it can construct a GrXferProcessor that reads the dst color.
+     */
+    virtual void onEmitShaderBlend(GrGLXPBuilder*, const char* srcColor, const char* dstColor,
+                                   const char* outColor, const GrXferProcessor&) {
+        SkFAIL("onEmitShaderBlend not implemented.");
+    }
 
     virtual void onSetData(const GrGLProgramDataManager&, const GrXferProcessor&) = 0;