Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp - Issue 1170523002: Removing GraphicsContext from ImageBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

Issue 1170523002: Removing GraphicsContext from ImageBuffer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix unit test crashes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

diff --git a/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp b/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

index b620a920c99400372d85b120be6f89e27fc4fd9a..25e2f50f1fd15b4b238d4dc1e8f400c027c8dc76 100644

--- a/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

+++ b/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

@@ -209,7 +209,9 @@ public:

{

m_testSurface->initializeCurrentFrame();

m_testSurface->getPicture();

- m_imageBuffer->context()->clearRect(FloatRect(FloatPoint(0, 0), FloatSize(m_testSurface->size())));

+ SkPaint clearPaint;

+ clearPaint.setXfermodeMode(SkXfermode::kClear_Mode);

+ m_imageBuffer->canvas()->drawRect(SkRect::MakeWH(m_testSurface->size().width(), m_testSurface->size().height()), clearPaint);

m_fakeImageBufferClient->fakeDraw();

EXPECT_EQ(1, m_fakeImageBufferClient->frameCount());

m_testSurface->getPicture();