Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1170523002: Removing GraphicsContext from ImageBuffer (Closed)

Created:
5 years, 6 months ago by Justin Novosad
Modified:
5 years, 6 months ago
Reviewers:
chrishtr, Stephen White
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-rendering, Rik, danakj, dcheng, dglazkov+blink, dshwang, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing GraphicsContext from ImageBuffer BUG=453113 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197051

Patch Set 1 #

Patch Set 2 : fix unit test crashes #

Total comments: 2

Patch Set 3 : fix mac #

Patch Set 4 : mac build #

Patch Set 5 : refect #

Patch Set 6 : fix mac build for realz #

Patch Set 7 : fix for shape bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -132 lines) Patch
M Source/core/frame/ImageBitmap.cpp View 1 2 3 4 2 chunks +3 lines, -11 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 2 3 4 5 3 chunks +6 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/layout/shapes/Shape.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/paint/ThemePainterMac.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/DragImage.cpp View 1 2 3 4 2 chunks +33 lines, -38 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContextTest.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 1 2 3 4 6 chunks +2 lines, -22 lines 0 comments Download
M Source/platform/graphics/ImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageBufferSurface.cpp View 1 chunk +3 lines, -12 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M Source/platform/mac/LocalCurrentGraphicsContext.h View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
M Source/platform/mac/LocalCurrentGraphicsContext.mm View 1 2 3 4 5 2 chunks +15 lines, -9 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.mm View 1 2 3 4 chunks +15 lines, -8 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm View 1 2 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Justin Novosad
PTAL
5 years, 6 months ago (2015-06-04 17:56:53 UTC) #2
Stephen White
LGTM! https://codereview.chromium.org/1170523002/diff/20001/Source/core/frame/ImageBitmap.cpp File Source/core/frame/ImageBitmap.cpp (right): https://codereview.chromium.org/1170523002/diff/20001/Source/core/frame/ImageBitmap.cpp#newcode87 Source/core/frame/ImageBitmap.cpp:87: buffer->canvas()->drawPicture(recording.get()); chrishtr@: Not new to this patch, but ...
5 years, 6 months ago (2015-06-04 18:33:10 UTC) #3
chrishtr
https://codereview.chromium.org/1170523002/diff/20001/Source/core/frame/ImageBitmap.cpp File Source/core/frame/ImageBitmap.cpp (right): https://codereview.chromium.org/1170523002/diff/20001/Source/core/frame/ImageBitmap.cpp#newcode87 Source/core/frame/ImageBitmap.cpp:87: buffer->canvas()->drawPicture(recording.get()); Agree that this looks wrong and we should ...
5 years, 6 months ago (2015-06-04 19:58:00 UTC) #4
Justin Novosad
On 2015/06/04 19:58:00, chrishtr wrote: > https://codereview.chromium.org/1170523002/diff/20001/Source/core/frame/ImageBitmap.cpp > File Source/core/frame/ImageBitmap.cpp (right): > > https://codereview.chromium.org/1170523002/diff/20001/Source/core/frame/ImageBitmap.cpp#newcode87 > ...
5 years, 6 months ago (2015-06-05 02:20:45 UTC) #5
chrishtr
On 2015/06/05 at 02:20:45, junov wrote: > On 2015/06/04 19:58:00, chrishtr wrote: > > https://codereview.chromium.org/1170523002/diff/20001/Source/core/frame/ImageBitmap.cpp ...
5 years, 6 months ago (2015-06-05 04:59:09 UTC) #6
Justin Novosad
re-review ping. This cl now draws directly into SkCanvas instead of using SkPictureBuilder in ImageBitmap ...
5 years, 6 months ago (2015-06-12 15:52:43 UTC) #7
chrishtr
lgtm
5 years, 6 months ago (2015-06-12 16:08:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170523002/100001
5 years, 6 months ago (2015-06-12 16:08:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170523002/120001
5 years, 6 months ago (2015-06-12 17:03:29 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 18:13:21 UTC) #16
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197051

Powered by Google App Engine
This is Rietveld 408576698