Initial Timeline Events

runtime/vm/deopt_instructions.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/deopt_instructions.h"
 
 #include "vm/assembler.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/intermediate_language.h"
 #include "vm/locations.h"
 #include "vm/parser.h"
 #include "vm/stack_frame.h"
 #include "vm/thread.h"
+#include "vm/timeline.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, compress_deopt_info, true,
             "Compress the size of the deoptimization info for optimized code.");
 DECLARE_FLAG(bool, trace_deoptimization);
 DECLARE_FLAG(bool, trace_deoptimization_verbose);
 
 
 DeoptContext::DeoptContext(const StackFrame* frame,
                            const Code& code,
                            DestFrameOptions dest_options,
                            fpu_register_t* fpu_registers,
                            intptr_t* cpu_registers)
     : code_(code.raw()),
       object_pool_(code.ObjectPool()),
       deopt_info_(TypedData::null()),
       dest_frame_is_allocated_(false),
       dest_frame_(NULL),
       dest_frame_size_(0),
       source_frame_is_allocated_(false),
       source_frame_(NULL),
       source_frame_size_(0),
       cpu_registers_(cpu_registers),
       fpu_registers_(fpu_registers),
       num_args_(0),
       deopt_reason_(ICData::kDeoptUnknown),
       deopt_flags_(0),
       thread_(Thread::Current()),
+      timeline_event_(NULL),
       deferred_slots_(NULL),
       deferred_objects_count_(0),
       deferred_objects_(NULL) {
   const TypedData& deopt_info = TypedData::Handle(
       code.GetDeoptInfoAtPc(frame->pc(), &deopt_reason_, &deopt_flags_));
   ASSERT(!deopt_info.IsNull());
   deopt_info_ = deopt_info.raw();
 
   const Function& function = Function::Handle(code.function());
 
@@ skipping 31 matching lines @@
 
   if (dest_options == kDestIsAllocated) {
     dest_frame_ = new intptr_t[dest_frame_size_];
     ASSERT(source_frame_ != NULL);
     for (intptr_t i = 0; i < dest_frame_size_; i++) {
       dest_frame_[i] = 0;
     }
     dest_frame_is_allocated_ = true;
   }
 
+  if (dest_options != kDestIsAllocated) {
+    // kDestIsAllocated is used by the debugger to generate a stack trace
+    // and does not signal a real deopt.
+    Isolate* isolate = Isolate::Current();
+    TimelineStream* compiler_stream = isolate->GetCompilerStream();
+    timeline_event_ = compiler_stream->RecordEvent();
+    if (timeline_event_ != NULL) {
+      timeline_event_->DurationBegin(compiler_stream, "Deoptimize");
+      timeline_event_->SetNumArguments(3);
+      timeline_event_->CopyArgument(
+          0,
+          "function",
+          const_cast<char*>(function.QualifiedUserVisibleNameCString()));

[rmacnak, 2015/06/10 20:25:14]

The whole leaf runtime entry is in a NoSafepointScope, so either use name()
instead or QualifiedUserVisibleNameCString needs to concatenate C strings
instead of Dart strings. 

[Cutch, 2015/06/10 21:20:57]

Done.

+      timeline_event_->CopyArgument(
+          1,
+          "reason",
+          const_cast<char*>(DeoptReasonToCString(deopt_reason())));
+      timeline_event_->FormatArgument(
+          2,
+          "deoptimizationCount",
+          "%d",
+          function.deoptimization_counter());
+    }
+  }
+
   if (FLAG_trace_deoptimization || FLAG_trace_deoptimization_verbose) {
     OS::PrintErr(
         "Deoptimizing (reason %d '%s') at pc %#" Px " '%s' (count %d)\n",
         deopt_reason(),
         DeoptReasonToCString(deopt_reason()),
         frame->pc(),
         function.ToFullyQualifiedCString(),
         function.deoptimization_counter());
   }
 }
@@ skipping 14 matching lines @@
   }
   dest_frame_ = NULL;
 
   // Delete all deferred objects.
   for (intptr_t i = 0; i < deferred_objects_count_; i++) {
     delete deferred_objects_[i];
   }
   delete[] deferred_objects_;
   deferred_objects_ = NULL;
   deferred_objects_count_ = 0;
+  if (timeline_event_ != NULL) {
+    timeline_event_->DurationEnd();
+  }
 }
 
 
 void DeoptContext::VisitObjectPointers(ObjectPointerVisitor* visitor) {
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&object_pool_));
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&deopt_info_));
 
   // Visit any object pointers on the destination stack.
   if (dest_frame_is_allocated_) {
     for (intptr_t i = 0; i < dest_frame_size_; i++) {
@@ skipping 1121 matching lines @@
                           Smi* offset,
                           TypedData* info,
                           Smi* reason) {
   intptr_t i = index * kEntrySize;
   *offset ^= table.At(i);
   *info ^= table.At(i + 1);
   *reason ^= table.At(i + 2);
 }
 
 }  // namespace dart