Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: Source/core/fetch/ResourceFetcher.h

Issue 1170503003: Remove resource type-specific fetching logic from ResourceFetcher (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Null-check Document::loader() before calling startPreload() Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fetch/Resource.h ('k') | Source/core/fetch/ResourceFetcher.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/ResourceFetcher.h
diff --git a/Source/core/fetch/ResourceFetcher.h b/Source/core/fetch/ResourceFetcher.h
index f9f09c71926b09f66c58c654588e569c0265f3b6..427069d1c29c57411abbf21478a4fd75a2541475 100644
--- a/Source/core/fetch/ResourceFetcher.h
+++ b/Source/core/fetch/ResourceFetcher.h
@@ -73,20 +73,7 @@ public:
virtual ~ResourceFetcher();
DECLARE_VIRTUAL_TRACE();
- ResourcePtr<Resource> fetchSynchronously(FetchRequest&);
- ResourcePtr<ImageResource> fetchImage(FetchRequest&);
- ResourcePtr<CSSStyleSheetResource> fetchCSSStyleSheet(FetchRequest&);
- ResourcePtr<ScriptResource> fetchScript(FetchRequest&);
- ResourcePtr<FontResource> fetchFont(FetchRequest&);
- ResourcePtr<RawResource> fetchRawResource(FetchRequest&);
- ResourcePtr<RawResource> fetchMainResource(FetchRequest&, const SubstituteData&);
- ResourcePtr<DocumentResource> fetchSVGDocument(FetchRequest&);
- ResourcePtr<XSLStyleSheetResource> fetchXSLStyleSheet(FetchRequest&);
- ResourcePtr<Resource> fetchLinkResource(Resource::Type, FetchRequest&);
- ResourcePtr<Resource> fetchLinkPreloadResource(Resource::Type, FetchRequest&);
- ResourcePtr<RawResource> fetchImport(FetchRequest&);
- ResourcePtr<RawResource> fetchMedia(FetchRequest&);
- ResourcePtr<RawResource> fetchTextTrack(FetchRequest&);
+ ResourcePtr<Resource> requestResource(FetchRequest&, const ResourceFactory&);
Resource* cachedResource(const KURL&) const;
@@ -109,7 +96,7 @@ public:
bool isPreloaded(const KURL&) const;
void clearPreloads();
- void preload(Resource::Type, FetchRequest&, const String& charset);
+ void preloadStarted(Resource*);
void printPreloadStats();
void addAllArchiveResources(MHTMLArchive*);
@@ -155,23 +142,23 @@ public:
String getCacheIdentifier() const;
+ void scheduleDocumentResourcesGC();
+ bool clientDefersImage(const KURL&) const;
+ void determineRequestContext(ResourceRequest&, Resource::Type);
+
private:
friend class ResourceCacheValidationSuppressor;
explicit ResourceFetcher(PassOwnPtrWillBeRawPtr<FetchContext>);
- ResourcePtr<Resource> requestResource(Resource::Type, FetchRequest&);
- ResourcePtr<Resource> createResourceForRevalidation(const FetchRequest&, Resource*);
- ResourcePtr<Resource> createResourceForLoading(Resource::Type, FetchRequest&, const String& charset);
- void preCacheDataURIImage(const FetchRequest&);
- void preCacheSubstituteDataForMainResource(const FetchRequest&, const SubstituteData&);
+ ResourcePtr<Resource> createResourceForRevalidation(const FetchRequest&, Resource*, const ResourceFactory&);
+ ResourcePtr<Resource> createResourceForLoading(FetchRequest&, const String& charset, const ResourceFactory&);
void storeResourceTimingInitiatorInformation(Resource*);
bool scheduleArchiveLoad(Resource*, const ResourceRequest&);
enum RevalidationPolicy { Use, Revalidate, Reload, Load };
RevalidationPolicy determineRevalidationPolicy(Resource::Type, const FetchRequest&, Resource* existingResource) const;
- void determineRequestContext(ResourceRequest&, Resource::Type);
void addAdditionalRequestHeaders(ResourceRequest&, Resource::Type);
static bool resourceNeedsLoad(Resource*, const FetchRequest&, RevalidationPolicy);
@@ -179,11 +166,9 @@ private:
void notifyLoadedFromMemoryCache(Resource*);
void garbageCollectDocumentResourcesTimerFired(Timer<ResourceFetcher>*);
- void scheduleDocumentResourcesGC();
void resourceTimingReportTimerFired(Timer<ResourceFetcher>*);
- bool clientDefersImage(const KURL&) const;
void reloadImagesIfNotDeferred();
void willTerminateResourceLoader(ResourceLoader*);
« no previous file with comments | « Source/core/fetch/Resource.h ('k') | Source/core/fetch/ResourceFetcher.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698