Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: Source/core/fetch/ImageResourceTest.cpp

Issue 1170503003: Remove resource type-specific fetching logic from ResourceFetcher (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Null-check Document::loader() before calling startPreload() Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fetch/ImageResource.cpp ('k') | Source/core/fetch/LinkFetchResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/ImageResourceTest.cpp
diff --git a/Source/core/fetch/ImageResourceTest.cpp b/Source/core/fetch/ImageResourceTest.cpp
index f9948af238a9143588c4821098de8225c64557ff..9972285673d05cceebb7cee5fb506c4af28945ad 100644
--- a/Source/core/fetch/ImageResourceTest.cpp
+++ b/Source/core/fetch/ImageResourceTest.cpp
@@ -89,7 +89,7 @@ TEST(ImageResourceTest, MultipartImage)
URLTestHelpers::registerMockedURLLoad(testURL, "cancelTest.html", "text/html");
// Emulate starting a real load, but don't expect any "real" WebURLLoaderClient callbacks.
- ResourcePtr<ImageResource> cachedImage = new ImageResource(ResourceRequest(testURL));
+ ResourcePtr<ImageResource> cachedImage = new ImageResource(ResourceRequest(testURL), nullptr);
cachedImage->setIdentifier(createUniqueIdentifier());
cachedImage->load(fetcher.get(), ResourceLoaderOptions());
Platform::current()->unitTestSupport()->unregisterMockedURL(testURL);
@@ -146,7 +146,7 @@ TEST(ImageResourceTest, CancelOnDetach)
RefPtrWillBeRawPtr<ResourceFetcher> fetcher = ResourceFetcher::create(nullptr);
// Emulate starting a real load.
- ResourcePtr<ImageResource> cachedImage = new ImageResource(ResourceRequest(testURL));
+ ResourcePtr<ImageResource> cachedImage = new ImageResource(ResourceRequest(testURL), nullptr);
cachedImage->setIdentifier(createUniqueIdentifier());
cachedImage->load(fetcher.get(), ResourceLoaderOptions());
@@ -171,7 +171,7 @@ TEST(ImageResourceTest, CancelOnDetach)
TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)
{
- ResourcePtr<ImageResource> cachedImage = new ImageResource(ResourceRequest());
+ ResourcePtr<ImageResource> cachedImage = new ImageResource(ResourceRequest(), nullptr);
cachedImage->setLoading(true);
MockImageResourceClient client;
@@ -205,7 +205,7 @@ TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)
TEST(ImageResourceTest, UpdateBitmapImages)
{
- ResourcePtr<ImageResource> cachedImage = new ImageResource(ResourceRequest());
+ ResourcePtr<ImageResource> cachedImage = new ImageResource(ResourceRequest(), nullptr);
cachedImage->setLoading(true);
MockImageResourceClient client;
« no previous file with comments | « Source/core/fetch/ImageResource.cpp ('k') | Source/core/fetch/LinkFetchResource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698