Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: Source/bindings/core/v8/ScriptStreamerTest.cpp

Issue 1170503003: Remove resource type-specific fetching logic from ResourceFetcher (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Null-check Document::loader() before calling startPreload() Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8ScriptRunnerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptStreamerTest.cpp
diff --git a/Source/bindings/core/v8/ScriptStreamerTest.cpp b/Source/bindings/core/v8/ScriptStreamerTest.cpp
index b44c687fc4e61b852591a5dada661bc8bed42349..de7758b45e6965c6e48633e057d9f3ebca4d7db8 100644
--- a/Source/bindings/core/v8/ScriptStreamerTest.cpp
+++ b/Source/bindings/core/v8/ScriptStreamerTest.cpp
@@ -67,8 +67,8 @@ public:
: m_scope(v8::Isolate::GetCurrent())
, m_settings(Settings::create())
, m_resourceRequest("http://www.streaming-test.com/")
- , m_resource(ScriptResource::create(m_resourceRequest, "UTF-8").leakPtr())
- , m_pendingScript(PendingScriptWrapper::create(0, m_resource)) // Takes ownership of m_resource.
+ , m_resource(new ScriptResource(m_resourceRequest, "UTF-8"))
+ , m_pendingScript(PendingScriptWrapper::create(0, m_resource.get()))
{
m_resource->setLoading(true);
ScriptStreamer::setSmallScriptThresholdForTesting(0);
@@ -122,7 +122,7 @@ protected:
// fetch any data outside the test; the test controls the data by calling
// ScriptResource::appendData.
ResourceRequest m_resourceRequest;
- ScriptResource* m_resource;
+ ResourcePtr<ScriptResource> m_resource;
OwnPtrWillBePersistent<PendingScriptWrapper> m_pendingScript;
};
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8ScriptRunnerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698