Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: Source/core/fetch/CachingCorrectnessTest.cpp

Issue 1170503003: Remove resource type-specific fetching logic from ResourceFetcher (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/fetch/CachingCorrectnessTest.cpp
diff --git a/Source/core/fetch/CachingCorrectnessTest.cpp b/Source/core/fetch/CachingCorrectnessTest.cpp
index 9071c165b1612dd6803c62bd7497d8c70b98d990..4c75e9aa1d2270b87e1de68ae7dfe5d78e1a50d0 100644
--- a/Source/core/fetch/CachingCorrectnessTest.cpp
+++ b/Source/core/fetch/CachingCorrectnessTest.cpp
@@ -33,6 +33,7 @@
#include "core/fetch/FetchContext.h"
#include "core/fetch/ImageResource.h"
#include "core/fetch/MemoryCache.h"
+#include "core/fetch/RawResource.h"
#include "core/fetch/Resource.h"
#include "core/fetch/ResourceFetcher.h"
#include "core/fetch/ResourcePtr.h"
@@ -109,13 +110,13 @@ protected:
ResourcePtr<Resource> fetch()
{
FetchRequest fetchRequest(ResourceRequest(KURL(ParsedURLString, kResourceURL)), FetchInitiatorInfo());
- return m_fetcher->fetchSynchronously(fetchRequest);
+ return RawResource::fetchSynchronously(fetchRequest, fetcher());
}
ResourcePtr<Resource> fetchImage()
{
FetchRequest fetchRequest(ResourceRequest(KURL(ParsedURLString, kResourceURL)), FetchInitiatorInfo());
- return m_fetcher->fetchImage(fetchRequest);
+ return ImageResource::fetch(fetchRequest, fetcher());
}
ResourceFetcher* fetcher() const { return m_fetcher.get(); }
@@ -471,7 +472,7 @@ TEST_F(CachingCorrectnessTest, PostToSameURLTwice)
ResourceRequest request2(KURL(ParsedURLString, kResourceURL));
request2.setHTTPMethod("POST");
FetchRequest fetch2(request2, FetchInitiatorInfo());
- ResourcePtr<Resource> resource2 = fetcher()->fetchSynchronously(fetch2);
+ ResourcePtr<Resource> resource2 = RawResource::fetchSynchronously(fetch2, fetcher());
EXPECT_EQ(resource2, memoryCache()->resourceForURL(request2.url()));
EXPECT_NE(resource1, resource2);

Powered by Google App Engine
This is Rietveld 408576698