Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1170463002: PPC: [date] Refactor the %_DateField intrinsic to be optimizable. (Closed)

Created:
5 years, 6 months ago by MTBrandyberry
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [date] Refactor the %_DateField intrinsic to be optimizable. Port e4782a9b468258344d512a5f7dadbf1584928849 Original commit message: Previously the %_DateField intrinsic would also check the object and throw an exception if you happen to pass something that is not a valid JSDate, which (a) violates our policy for instrinsics and (b) is hard to optimize in TurboFan (even Crankshaft has a hard time, but there we will never inline the relevant builtins, so it doesn't show up). The throwing part is now a separate intrinsics %_ThrowIfNotADate that throws an exception in full codegen and deoptimizes in Crankshaft, which means the code for the current use cases is roughly the same (modulo some register renamings/gap moves). R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/92d5c48f743f370c9437008e05b0cb7c75857176 Cr-Commit-Position: refs/heads/master@{#28794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M src/ppc/full-codegen-ppc.cc View 3 chunks +25 lines, -11 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 6 months ago (2015-06-03 16:54:57 UTC) #1
dstence
lgtm
5 years, 6 months ago (2015-06-03 16:57:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170463002/1
5 years, 6 months ago (2015-06-03 16:58:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 17:22:04 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 17:22:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92d5c48f743f370c9437008e05b0cb7c75857176
Cr-Commit-Position: refs/heads/master@{#28794}

Powered by Google App Engine
This is Rietveld 408576698