Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 1170433002: [turbofan] Don't lower to NumberModulus unless the inputs are numbers. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't lower to NumberModulus unless the inputs are numbers. The IC for modulus is usually way faster than converting the inputs to numbers and doing a Float64Mod on them. R=jarin@chromium.org Committed: https://crrev.com/daba339a84c75f5edac6f60eb079b563970260b9 Cr-Commit-Position: refs/heads/master@{#28787}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-03 09:47:52 UTC) #1
Benedikt Meurer
Hey Jaro, This is the quick fix for JSModulus. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-03 09:48:52 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-03 09:52:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170433002/20001
5 years, 6 months ago (2015-06-03 10:30:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-03 11:24:18 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 11:24:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/daba339a84c75f5edac6f60eb079b563970260b9
Cr-Commit-Position: refs/heads/master@{#28787}

Powered by Google App Engine
This is Rietveld 408576698