Issue 1170413002: Make Sky not crash when an image 404s.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1170413002: Make Sky not crash when an image 404s. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium, jackson

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make Sky not crash when an image 404s. I also fixed image_cache to not even bother to call ImageDecoder in the 404 case, but I also fixed CanvasImageDecoder not to blow up if the buffer is empty and its not able to allocate an ImageDecoder. Closes https://github.com/domokit/mojo/issues/229 R=abarth@chromium.org, jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/672122646faa6979741ac02468647a98cf1357ee

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -12 lines)			Patch
	M	sky/engine/core/loader/CanvasImageDecoder.cpp	View		3 chunks	+16 lines, -7 lines	0 comments	Download
	M	sky/sdk/lib/framework/net/image_cache.dart	View		2 chunks	+12 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

eseidel

5 years, 6 months ago (2015-06-10 00:29:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
672122646faa6979741ac02468647a98cf1357ee (presubmit successful).