Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1170383003: Force property_trees rebuild for DamageTrackerTest (Closed)

Created:
5 years, 6 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 6 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force property_trees rebuild for DamageTrackerTest DamageTrackerTest does a lot of impl side operations that could not happen in practice, e.g. LayerImpl::SetPosition(), LayerImpl::Add/RemoveChild(). These operations won't trigger property trees rebuild/update so the verification on draw_transform would fail. The simple fix in this case seems to be forcing a property trees rebuild. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/5032027d92f1def6b0cc8a35607ad7bc74a56944 Cr-Commit-Position: refs/heads/master@{#333638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cc/trees/damage_tracker_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yufeng Shen (Slow to review)
5 years, 6 months ago (2015-06-10 00:06:19 UTC) #2
enne (OOO)
lgtm (Also, no need for a BUG=none line. You can remove that.)
5 years, 6 months ago (2015-06-10 00:09:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170383003/1
5 years, 6 months ago (2015-06-10 00:17:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 01:27:58 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 01:28:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5032027d92f1def6b0cc8a35607ad7bc74a56944
Cr-Commit-Position: refs/heads/master@{#333638}

Powered by Google App Engine
This is Rietveld 408576698