Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1170373002: ozone: evdev: Make sure to device list update during startup scan (Closed)

Created:
5 years, 6 months ago by spang
Modified:
5 years, 6 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Make sure to device list update during startup scan Device removal currently immediately updates the device list (ignoring pending_device_changes_), which could violate our promise to delay list updates until we've finished enumerating connected devices at startup. We make this promise to allow the UI to make decisions based on absence of devices once a full scan completes. This probably doesn't happen, but make it impossible anyway. Committed: https://crrev.com/4ebae701ff499f2afaadb79f39dd2a6b1f0f5a97 Cr-Commit-Position: refs/heads/master@{#333743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 6 months ago (2015-06-09 22:34:44 UTC) #2
kpschoedel
lgtm
5 years, 6 months ago (2015-06-09 23:13:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170373002/1
5 years, 6 months ago (2015-06-10 16:17:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 16:39:42 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 16:40:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ebae701ff499f2afaadb79f39dd2a6b1f0f5a97
Cr-Commit-Position: refs/heads/master@{#333743}

Powered by Google App Engine
This is Rietveld 408576698