Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issue 1170363003: Do not update the url text while in batch edit mode. (Closed)

Created:
5 years, 6 months ago by Ted C
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not update the url text while in batch edit mode. BUG=418701 Committed: https://crrev.com/0ce845f56f4903801e5063abfb4fd93e4c562770 Cr-Commit-Position: refs/heads/master@{#333800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M chrome/android/java_staging/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 5 chunks +29 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
5 years, 6 months ago (2015-06-10 01:56:05 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 6 months ago (2015-06-10 20:36:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170363003/1
5 years, 6 months ago (2015-06-10 20:47:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 21:13:55 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 21:14:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ce845f56f4903801e5063abfb4fd93e4c562770
Cr-Commit-Position: refs/heads/master@{#333800}

Powered by Google App Engine
This is Rietveld 408576698