[Proximity auth] Disallow '+' and '/' in incoming base64-encoded strings.

[Proximity auth] Disallow '+' and '/' in incoming base64-encoded strings.

BUG=498478
TEST=unit tested
R=rsleevi@chromium.org, tengs@chromium.org

Committed: https://crrev.com/28d29ae1356f3ba30f1e8fceb0d1707e759a5ebb
Cr-Commit-Position: refs/heads/master@{#333632}

[Tim Song, 2015-06-09 22:30:33]

lgtm

[Ilya Sherman, 2015-06-09 22:31:51]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2015-06-09 22:35:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1170363002/1

[Ryan Sleevi, 2015-06-09 22:39:49]

LGTM % nit

https://codereview.chromium.org/1170363002/diff/1/components/proximity_auth/c...
File components/proximity_auth/cryptauth/base64url_unittest.cc (right):

https://codereview.chromium.org/1170363002/diff/1/components/proximity_auth/c...
components/proximity_auth/cryptauth/base64url_unittest.cc:74: const std::string
encoded = "/-Y=";
Just to confirm: Are these valid b64strings otherwise? That is, is "/+Y=" valid?

It may help to add a comment to these tests to indicate what the encoded value
is, just so it's clear to not just stuff "any" value in here but it needs to be
one that would be easily confused if doing a 'dumb' search/replace

[Ilya Sherman, 2015-06-09 23:07:35]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2015-06-09 23:07:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tengs@chromium.org,
rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1170363002/#ps20001
(title: "Moar commants")

[Ilya Sherman, 2015-06-09 23:08:40]

https://codereview.chromium.org/1170363002/diff/1/components/proximity_auth/c...
File components/proximity_auth/cryptauth/base64url_unittest.cc (right):

https://codereview.chromium.org/1170363002/diff/1/components/proximity_auth/c...
components/proximity_auth/cryptauth/base64url_unittest.cc:74: const std::string
encoded = "/-Y=";
On 2015/06/09 22:39:48, Ryan Sleevi wrote:
> Just to confirm: Are these valid b64strings otherwise? That is, is "/+Y="
valid?
> 
> It may help to add a comment to these tests to indicate what the encoded value
> is, just so it's clear to not just stuff "any" value in here but it needs to
be
> one that would be easily confused if doing a 'dumb' search/replace

Done.  "/+Y=" is the string that's tested above; but I've now added explicit
comments to make this even clearer.

[commit-bot: I haz the power, 2015-06-09 23:11:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1170363002/20001

[Ryan Sleevi, 2015-06-09 23:13:57]

The CQ bit was unchecked by rsleevi@chromium.org

[Ryan Sleevi, 2015-06-09 23:14:02]

https://codereview.chromium.org/1170363002/diff/20001/components/proximity_au...
File components/proximity_auth/cryptauth/base64url_unittest.cc (right):

https://codereview.chromium.org/1170363002/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/base64url_unittest.cc:70: // in palce of
'-', since the proximity auth code expects websafe encodings.
typo: place

https://codereview.chromium.org/1170363002/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/base64url_unittest.cc:79: // in palce of
'_', since the proximity auth code expects websafe encodings.
typo: place

[Ilya Sherman, 2015-06-09 23:43:27]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2015-06-09 23:43:27]

The patchset sent to the CQ was uploaded after l-g-t-m from tengs@chromium.org,
rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1170363002/#ps40001
(title: "Fix a typo: 'palce' -> 'place'")

[commit-bot: I haz the power, 2015-06-09 23:44:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1170363002/40001

[commit-bot: I haz the power, 2015-06-10 01:10:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-10 01:11:56]

Patchset 3 (id:??) landed as
https://crrev.com/28d29ae1356f3ba30f1e8fceb0d1707e759a5ebb
Cr-Commit-Position: refs/heads/master@{#333632}