Remove use of set -x for verbose logging

Remove verbose bash logging

Committed: https://skia.googlesource.com/skia/+/46409de6abb1a41f13081a3460ad95b370b6b04b

[djsollen, 2015-06-10 18:05:36]

djsollen@google.com changed reviewers:
+ borenet@google.com

[borenet, 2015-06-10 18:07:58]

https://codereview.chromium.org/1170283004/diff/1/platform_tools/android/bin/...
File platform_tools/android/bin/android_setup.sh (left):

https://codereview.chromium.org/1170283004/diff/1/platform_tools/android/bin/...
platform_tools/android/bin/android_setup.sh:37: set -x
If we're getting rid of this, can we at least replace it with some logging? 
It's really nice to know which of the hundreds of calls to adb failed.

[djsollen, 2015-06-10 18:11:31]

On 2015/06/10 18:07:58, borenet wrote:
>
https://codereview.chromium.org/1170283004/diff/1/platform_tools/android/bin/...
> File platform_tools/android/bin/android_setup.sh (left):
> 
>
https://codereview.chromium.org/1170283004/diff/1/platform_tools/android/bin/...
> platform_tools/android/bin/android_setup.sh:37: set -x
> If we're getting rid of this, can we at least replace it with some logging? 
> It's really nice to know which of the hundreds of calls to adb failed.

sure.  what are the pain points? android_run_skia? adb_push/pull_if_neede?

[borenet, 2015-06-10 18:21:21]

On 2015/06/10 18:11:31, djsollen wrote:
> On 2015/06/10 18:07:58, borenet wrote:
> >
>
https://codereview.chromium.org/1170283004/diff/1/platform_tools/android/bin/...
> > File platform_tools/android/bin/android_setup.sh (left):
> > 
> >
>
https://codereview.chromium.org/1170283004/diff/1/platform_tools/android/bin/...
> > platform_tools/android/bin/android_setup.sh:37: set -x
> > If we're getting rid of this, can we at least replace it with some logging? 
> > It's really nice to know which of the hundreds of calls to adb failed.
> 
> sure.  what are the pain points? android_run_skia? adb_push/pull_if_neede?

The biggest is in android_run_skia where it does a bunch of work before actually
running the test.  We frequently fail somewhere during that work.  Honestly, I'm
not even sure what work is being done since AFAIK the recipe is pushing
everything that should be needed (with the exception of skia_launcher and
skia_lib)...

[borenet, 2015-06-10 19:28:44]

LGTM. Thanks.

[djsollen, 2015-06-10 19:31:48]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2015-06-10 19:31:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1170283004/20001

[commit-bot: I haz the power, 2015-06-10 19:37:59]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/46409de6abb1a41f13081a3460ad95b370b6b04b