Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1170273002: Oilpan: correctly define transition macro for eager finalization. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: correctly define transition macro for eager finalization. EAGERLY_FINALIZE_WILL_BE_REMOVED() needs to provide eager finalization outside of ENABLE(OILPAN), but only if lazy sweeping is enabled. R=haraken BUG=420522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196848

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/platform/heap/Heap.h View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
sof
please take a look. To avoid conflicts this needs to wait on https://codereview.chromium.org/1172603002/
5 years, 6 months ago (2015-06-09 16:35:16 UTC) #2
sof
The non-Oilpan fuzzer build will no doubt trip up on the lack of eager finalization ...
5 years, 6 months ago (2015-06-09 16:37:20 UTC) #3
haraken
LGTM
5 years, 6 months ago (2015-06-09 23:27:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170273002/20001
5 years, 6 months ago (2015-06-10 07:52:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196848
5 years, 6 months ago (2015-06-10 09:15:25 UTC) #8
vabr (Chromium)
I think you might have got the bug number wrong. :) Cheers, Vaclav
5 years, 6 months ago (2015-06-11 11:47:38 UTC) #9
sof
5 years, 6 months ago (2015-06-11 11:52:05 UTC) #10
Message was sent while issue was closed.
On 2015/06/11 11:47:38, vabr (Chromium) wrote:
> I think you might have got the bug number wrong. :)
> Cheers,
> Vaclav

Oops, sorry. 340522 and 420515 are two common Oilpan issues, I wanted the latter
here, but somehow managed to turn that into 420522.

Powered by Google App Engine
This is Rietveld 408576698