Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1170193002: [DevTools] Add uiTest.testSettings. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Add uiTest.testSettings. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196770

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M Source/devtools/front_end/Runtime.js View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 3 chunks +13 lines, -3 lines 0 comments Download
M Source/devtools/front_end/main/Tests.js View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
dgozman
Take a look please.
4 years, 10 months ago (2015-06-09 12:21:11 UTC) #2
dgozman
Take a look please.
4 years, 10 months ago (2015-06-09 12:22:28 UTC) #4
pfeldman
https://codereview.chromium.org/1170193002/diff/1/Source/devtools/front_end/main/Main.js File Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/1170193002/diff/1/Source/devtools/front_end/main/Main.js#newcode57 Source/devtools/front_end/main/Main.js:57: _resetSettingsForTest: function(callback) Why is this here? https://codereview.chromium.org/1170193002/diff/1/Source/devtools/front_end/main/Main.js#newcode76 Source/devtools/front_end/main/Main.js:76: _createSettings: ...
4 years, 10 months ago (2015-06-09 12:24:51 UTC) #5
pfeldman
https://codereview.chromium.org/1170193002/diff/1/Source/devtools/front_end/main/Main.js File Source/devtools/front_end/main/Main.js (left): https://codereview.chromium.org/1170193002/diff/1/Source/devtools/front_end/main/Main.js#oldcode106 Source/devtools/front_end/main/Main.js:106: this._createAppUI(); Just move this line to the call site ...
4 years, 10 months ago (2015-06-09 12:57:34 UTC) #6
dgozman
PTAL https://codereview.chromium.org/1170193002/diff/1/Source/devtools/front_end/main/Main.js File Source/devtools/front_end/main/Main.js (left): https://codereview.chromium.org/1170193002/diff/1/Source/devtools/front_end/main/Main.js#oldcode106 Source/devtools/front_end/main/Main.js:106: this._createAppUI(); On 2015/06/09 12:57:34, pfeldman wrote: > Just ...
4 years, 10 months ago (2015-06-09 13:55:35 UTC) #7
pfeldman
lgtm
4 years, 10 months ago (2015-06-09 13:56:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170193002/20001
4 years, 10 months ago (2015-06-09 13:57:15 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 15:04:03 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196770

Powered by Google App Engine
This is Rietveld 408576698