src/mips64/lithium-codegen-mips64.cc - Issue 1170173002: MIPS64: Fix bogus assert in AddI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/lithium-codegen-mips64.cc

Issue 1170173002: MIPS64: Fix bogus assert in AddI. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips64/lithium-codegen-mips64.cc

diff --git a/src/mips64/lithium-codegen-mips64.cc b/src/mips64/lithium-codegen-mips64.cc

index 4ca54d6a2bb32cb37ad01653fe0a4294559ebf03..66dc709c591b08feb60842643d74a0078f9bfcc0 100644

--- a/src/mips64/lithium-codegen-mips64.cc

+++ b/src/mips64/lithium-codegen-mips64.cc

@@ -1907,7 +1907,7 @@ void LCodeGen::DoAddI(LAddI* instr) {

bool can_overflow = instr->hydrogen()->CheckFlag(HValue::kCanOverflow);

if (!can_overflow) {

- DCHECK(right->IsRegister());

+ DCHECK(right->IsRegister() || right->IsConstantOperand());

__ Daddu(ToRegister(result), ToRegister(left), ToOperand(right));

} else { // can_overflow.

« no previous file with comments | « no previous file | no next file » | no next file with comments »