DevTools Timeline: expose HitTest event

Source/core/layout/LayoutView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 10 matching lines @@
 #include "config.h"
 #include "core/layout/LayoutView.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/editing/FrameSelection.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/html/HTMLIFrameElement.h"
+#include "core/inspector/InspectorTraceEvents.h"
 #include "core/layout/HitTestResult.h"
 #include "core/layout/LayoutFlowThread.h"
 #include "core/layout/LayoutGeometryMap.h"
 #include "core/layout/LayoutPart.h"
 #include "core/layout/LayoutQuote.h"
 #include "core/layout/LayoutScrollbarPart.h"
 #include "core/layout/compositing/DeprecatedPaintLayerCompositor.h"
 #include "core/page/Page.h"
 #include "core/paint/DeprecatedPaintLayer.h"
 #include "core/paint/ViewPainter.h"
@@ skipping 35 matching lines @@
 
 LayoutView::~LayoutView()
 {
 }
 
 bool LayoutView::hitTest(HitTestResult& result)
 {
     return hitTest(result.hitTestRequest(), result.hitTestLocation(), result);
 }
 
-namespace {
-
-PassRefPtr<TracedValue> hitTestInfo(const HitTestRequest& request, const HitTestLocation& location, const HitTestResult& result)
-{
-    RefPtr<TracedValue> value(TracedValue::create());
-    value->setInteger("x", location.roundedPoint().x());
-    value->setInteger("y", location.roundedPoint().y());
-    if (location.isRectBasedTest())
-        value->setBoolean("rect", true);
-    if (location.isRectilinear())
-        value->setBoolean("rectilinear", true);
-    if (request.touchEvent())
-        value->setBoolean("touch", true);
-    if (request.move())
-        value->setBoolean("move", true);
-    if (request.listBased()) {
-        value->setBoolean("listBased", true);
-    } else if (Node* node = result.innerNode()) {
-        value->setString("nodeAddress", String::format("%" PRIx64, static_cast<uint64>(reinterpret_cast<intptr_t>(node))));
-        value->setString("tag", node->nodeName());
-        Element* elem = result.innerElement();
-        if (elem && elem->hasID())
-            value->setString("htmlId", elem->getIdAttribute());
-    }
-    return value;
-}
-
-} // anonymous namespace
-
 bool LayoutView::hitTest(const HitTestRequest& request, const HitTestLocation& location, HitTestResult& result)
 {
-    TRACE_EVENT_BEGIN0("blink", "LayoutView::hitTest");
+    TRACE_EVENT_BEGIN0("blink,devtools.timeline", "HitTest");
     m_hitTestCount++;
 
     ASSERT(!location.isRectBasedTest() || request.listBased());
 
     // We have to recursively update layout/style here because otherwise, when the hit test recurses
     // into a child document, it could trigger a layout on the parent document, which can destroy DeprecatedPaintLayer
     // that are higher up in the call stack, leading to crashes.
     // Note that Document::updateLayout calls its parent's updateLayout.
     // FIXME: It should be the caller's responsibility to ensure an up-to-date layout.
     frameView()->updateLayoutAndStyleForPainting();
     commitPendingSelection();
 
     bool hitLayer = layer()->stackingNode()->hitTest(request, location, result);
 
     // FrameView scrollbars are not the same as Layer scrollbars tested by Layer::hitTestOverflowControls,
     // so we need to test FrameView scrollbars separately here. Note that it's important we do this after
     // the hit test above, because that may overwrite the entire HitTestResult when it finds a hit.
     IntPoint framePoint = frameView()->contentsToFrame(location.roundedPoint());
     if (Scrollbar* frameScrollbar = frameView()->scrollbarAtFramePoint(framePoint))
         result.setScrollbar(frameScrollbar);
 
-    TRACE_EVENT_END1("blink", "LayoutView::hitTest", "info", hitTestInfo(request, location, result));

[yurys, 2015/06/09 16:39:52]

Is there a special handling of the info param that needs to be updated in trace
viewer?

+    TRACE_EVENT_END1("blink,devtools.timeline", "HitTest", "endData", InspectorHitTestEvent::endData(request, location, result));
     return hitLayer;
 }
 
 void LayoutView::computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit, LogicalExtentComputedValues& computedValues) const
 {
     computedValues.m_extent = (!shouldUsePrintingLayout() && m_frameView) ? LayoutUnit(viewLogicalHeightForBoxSizing()) : logicalHeight;
 }
 
 void LayoutView::updateLogicalWidth()
 {
@@ skipping 824 matching lines @@
     return viewHeight(IncludeScrollbars) / scale;
 }
 
 void LayoutView::willBeDestroyed()
 {
     LayoutBlockFlow::willBeDestroyed();
     m_compositor.clear();
 }
 
 } // namespace blink