Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(253)

Issue 1170153004: DevTools Timeline: expose HitTest event (Closed)

Created:
4 years, 10 months ago by caseq
Modified:
4 years, 10 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, szager+layoutwatch_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, pfeldman+blink_chromium.org, blink-reviews-rendering, apavlov+blink_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools Timeline: expose HitTest event This renames LayoutView::hitTest trace event to HitTest and exposes it in Timeline. Also, event data builder is moved to IsnpectorTraceEvents and changed to match field names used through other timeline trace events. BUG=496341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196792

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -34 lines) Patch
A + LayoutTests/inspector/tracing/hit-test.html View 2 chunks +3 lines, -3 lines 0 comments Download
A LayoutTests/inspector/tracing/hit-test-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 2 chunks +21 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 3 chunks +3 lines, -31 lines 1 comment Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
4 years, 10 months ago (2015-06-09 16:10:46 UTC) #2
yurys
lgtm https://codereview.chromium.org/1170153004/diff/1/Source/core/layout/LayoutView.cpp File Source/core/layout/LayoutView.cpp (left): https://codereview.chromium.org/1170153004/diff/1/Source/core/layout/LayoutView.cpp#oldcode139 Source/core/layout/LayoutView.cpp:139: TRACE_EVENT_END1("blink", "LayoutView::hitTest", "info", hitTestInfo(request, location, result)); Is there ...
4 years, 10 months ago (2015-06-09 16:39:52 UTC) #3
caseq
On 2015/06/09 16:39:52, yurys wrote: > > https://codereview.chromium.org/1170153004/diff/1/Source/core/layout/LayoutView.cpp > File Source/core/layout/LayoutView.cpp (left): > > https://codereview.chromium.org/1170153004/diff/1/Source/core/layout/LayoutView.cpp#oldcode139 ...
4 years, 10 months ago (2015-06-09 16:42:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170153004/1
4 years, 10 months ago (2015-06-09 16:42:59 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 19:06:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196792

Powered by Google App Engine
This is Rietveld 408576698