Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 1170153002: SVG: Escape non-ASCII characters in console messages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/transform-parser-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 0744f7b855f660958d3824fa3da28304a2ad9a6b..2350b67978617ad48b005ff89b016fc98f1cc30c 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -48,7 +48,7 @@
#include "core/svg/SVGSVGElement.h"
#include "core/svg/SVGTitleElement.h"
#include "core/svg/SVGUseElement.h"
-
+#include "platform/JSONValues.h"
#include "wtf/TemporaryChange.h"
namespace blink {
@@ -186,7 +186,7 @@ void SVGElement::reportAttributeParsingError(SVGParsingError error, const Qualif
if (error == NoError)
return;
- String errorString = "<" + tagName() + "> attribute " + name.toString() + "=\"" + value + "\"";
+ String errorString = "<" + tagName() + "> attribute " + name.toString() + "=" + JSONValue::quoteString(value);
SVGDocumentExtensions& extensions = document().accessSVGExtensions();
if (error == NegativeValueForbiddenError) {
« no previous file with comments | « LayoutTests/svg/dom/transform-parser-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698