Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1170123004: Rename CompiledFunction to FletchFunctionBuilder and CompiledClass to FletchClassBuilder. (Closed)

Created:
5 years, 6 months ago by Anders Johnsen
Modified:
5 years, 6 months ago
Reviewers:
Johnni Winther, ahe, kasperl
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename CompiledFunction to FletchFunctionBuilder and CompiledClass to FletchClassBuilder. BUG= R=ahe@google.com, johnniwinther@google.com Committed: https://github.com/dart-lang/fletch/commit/b8ba7bb43e6879fdbf4f06e6e24c5b9ae3445fe4

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -815 lines) Patch
M pkg/fletchc/lib/compiler.dart View 1 7 chunks +22 lines, -21 lines 0 comments Download
M pkg/fletchc/lib/incremental/library_updater.dart View 1 8 chunks +16 lines, -16 lines 0 comments Download
M pkg/fletchc/lib/src/closure_environment.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/fletchc/lib/src/codegen_visitor.dart View 22 chunks +55 lines, -53 lines 0 comments Download
D pkg/fletchc/lib/src/compiled_class.dart View 1 chunk +0 lines, -141 lines 0 comments Download
D pkg/fletchc/lib/src/compiled_function.dart View 1 chunk +0 lines, -312 lines 0 comments Download
M pkg/fletchc/lib/src/constructor_codegen.dart View 10 chunks +23 lines, -23 lines 0 comments Download
M pkg/fletchc/lib/src/debug_info.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/fletchc/lib/src/debug_info_constructor_codegen.dart View 3 chunks +13 lines, -13 lines 0 comments Download
M pkg/fletchc/lib/src/debug_info_function_codegen.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M pkg/fletchc/lib/src/debug_info_lazy_field_initializer_codegen.dart View 1 3 chunks +11 lines, -11 lines 0 comments Download
M pkg/fletchc/lib/src/fletch_backend.dart View 1 37 chunks +143 lines, -140 lines 0 comments Download
A + pkg/fletchc/lib/src/fletch_class_builder.dart View 6 chunks +14 lines, -12 lines 0 comments Download
M pkg/fletchc/lib/src/fletch_compiler.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + pkg/fletchc/lib/src/fletch_function_builder.dart View 10 chunks +36 lines, -35 lines 0 comments Download
M pkg/fletchc/lib/src/function_codegen.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/fletchc/lib/src/lazy_field_initializer_codegen.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/fletchc/lib/stack_trace.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Anders Johnsen
No behavior change. Next step is to introduce the following immutables: - FletchFunction - FletchClass ...
5 years, 6 months ago (2015-06-09 09:09:13 UTC) #2
ahe
lgtm Great to see this get started! https://codereview.chromium.org/1170123004/diff/1/pkg/fletchc/lib/compiler.dart File pkg/fletchc/lib/compiler.dart (right): https://codereview.chromium.org/1170123004/diff/1/pkg/fletchc/lib/compiler.dart#newcode246 pkg/fletchc/lib/compiler.dart:246: FletchFunctionBuilder function ...
5 years, 6 months ago (2015-06-09 09:14:56 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/1170123004/diff/1/pkg/fletchc/lib/incremental/library_updater.dart File pkg/fletchc/lib/incremental/library_updater.dart (right): https://codereview.chromium.org/1170123004/diff/1/pkg/fletchc/lib/incremental/library_updater.dart#newcode865 pkg/fletchc/lib/incremental/library_updater.dart:865: FletchClassBuilder classBuilder = backend.classBuilderes[element]; classBuilderes -> classBuilders (throughout)
5 years, 6 months ago (2015-06-09 09:24:33 UTC) #4
Anders Johnsen
https://codereview.chromium.org/1170123004/diff/1/pkg/fletchc/lib/compiler.dart File pkg/fletchc/lib/compiler.dart (right): https://codereview.chromium.org/1170123004/diff/1/pkg/fletchc/lib/compiler.dart#newcode246 pkg/fletchc/lib/compiler.dart:246: FletchFunctionBuilder function = _compiler.context.backend.functions[methodId]; On 2015/06/09 09:14:56, ahe wrote: ...
5 years, 6 months ago (2015-06-09 10:15:41 UTC) #5
Anders Johnsen
5 years, 6 months ago (2015-06-09 10:15:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b8ba7bb43e6879fdbf4f06e6e24c5b9ae3445fe4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698