Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1170123002: Revert of [autofill] Sync server card and address metadata. (Closed)

Created:
5 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [autofill] Sync server card and address metadata. (patchset #8 id:820001 of https://codereview.chromium.org/1110833002/) Reason for revert: Chrome Stability sheriff here--I suspect that this is causing crashes on Win, Mac and Android (maybe everything); see https://code.google.com/p/chromium/issues/detail?id=497659#c6 Original issue's description: > [autofill] Sync server card and address metadata. > > BUG=481595 > > Committed: https://crrev.com/7c5be3bcf846d4de1d552342f46abb793127f5c5 > Cr-Commit-Position: refs/heads/master@{#333202} TBR=estade@chromium.org,zea@chromium.org,pkasting@chromium.org,rouslan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=481595 Committed: https://crrev.com/df8814b6252330f3858e72b806b1cffa5dd966ae Cr-Commit-Position: refs/heads/master@{#333448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1497 lines) Patch
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M components/autofill.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_change.h View 3 chunks +1 line, -22 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_change.cc View 2 chunks +10 lines, -22 lines 0 comments Download
D components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h View 1 chunk +0 lines, -150 lines 0 comments Download
D components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc View 1 chunk +0 lines, -460 lines 0 comments Download
D components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc View 1 chunk +0 lines, -771 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc View 6 chunks +11 lines, -46 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_service_observer.h View 1 chunk +0 lines, -8 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/webdata_services/web_data_service_wrapper.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M sync/api/sync_data.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dominicc (has gone to gerrit)
Created Revert of [autofill] Sync server card and address metadata.
5 years, 6 months ago (2015-06-09 05:09:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170123002/1
5 years, 6 months ago (2015-06-09 05:09:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 05:10:53 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/df8814b6252330f3858e72b806b1cffa5dd966ae Cr-Commit-Position: refs/heads/master@{#333448}
5 years, 6 months ago (2015-06-09 05:11:52 UTC) #4
please use gerrit instead
5 years, 6 months ago (2015-06-09 14:49:50 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698