Issue 1170033005: Add some TODOs for renaming onTick and onValueChanged.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1170033005: Add some TODOs for renaming onTick and onValueChanged. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add some TODOs for renaming onTick and onValueChanged. I'd do it now, but these files are still being used by fn.dart/stocks1, and it's not worth forking the whole animation directory just for this. TBR=abarth Committed: https://chromium.googlesource.com/external/mojo/+/be11a31f6b1662f9f1e4875f35b07df21feda7d3

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sky/sdk/lib/framework/animation/animated_value.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	sky/sdk/lib/framework/animation/generators.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Hixie

5 years, 6 months ago (2015-06-10 20:43:46 UTC) #1

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
be11a31f6b1662f9f1e4875f35b07df21feda7d3 (presubmit successful).