Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1170023002: Implement %TypedArray%.prototype.slice (Closed)

Created:
5 years, 6 months ago by dehrenberg
Modified:
5 years, 6 months ago
CC:
v8-dev, vogelheim, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement %TypedArray%.prototype.slice The initial implementation of this method takes a couple shortcuts: - At some points in the spec, we should be making a reference to "Table 49" and instead do property lookup on the constructor. This is an issue with some other TypedArray methods too. - The spec indicates that, if constructor and @@species haven't been messed with in particular ways, then there should be a memcpy from the old to the new. That fast path is not implemented here in this patch, but because V8 doesn't canonicalize NaN, the result isn't observably different. BUG=v8:3578 LOG=Y R=arv Committed: https://crrev.com/51df8df9bef4913559d6a356e26ed2596ba1509f Cr-Commit-Position: refs/heads/master@{#28882}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -4 lines) Patch
M src/harmony-typedarray.js View 5 chunks +56 lines, -4 lines 1 comment Download
A test/mjsunit/harmony/typedarray-slice.js View 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dehrenberg
5 years, 6 months ago (2015-06-08 23:18:50 UTC) #1
arv (Not doing code reviews)
LGTM I'm not sure how to test Set throwing? I don't see how it can ...
5 years, 6 months ago (2015-06-08 23:57:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170023002/1
5 years, 6 months ago (2015-06-09 18:18:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 19:40:48 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/51df8df9bef4913559d6a356e26ed2596ba1509f Cr-Commit-Position: refs/heads/master@{#28882}
5 years, 6 months ago (2015-06-09 19:41:09 UTC) #6
Michael Achenbach
5 years, 6 months ago (2015-06-10 07:06:59 UTC) #8
Message was sent while issue was closed.
Something is missing in the build deps. The builder that built this CL made the
external snapshot (including the experimental libraries):
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20builder/bui...

@vogelheim, yangguo: There was no linking of d8, guess that is expected? Still,
something is missing since the tests failed (e.g.
http://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/3799) and a
full rebuild in the next commit solved the problem.

Powered by Google App Engine
This is Rietveld 408576698