Convert BrowserPlugin to render using cc::Surfaces.

Convert BrowserPlugin to render using cc::Surfaces.

This CL adds the appropriate machinery to allow BrowserPlugin to render
using surfaces. This directly affects WebView and other GuestView
types, such as the out-of-process PDF viewer.

Where possible, functionality in RenderWidgetHostViewChildFrame that did
not need to be replicated in RenderWidgetHostViewGuest was left
untouched.

This CL is based closely on https://codereview.chromium.org/1094113003/.

BUG=none

Committed: https://crrev.com/53032adf732a092a342ae1ef2f3039adf89082d1
Cr-Commit-Position: refs/heads/master@{#334392}

[wjmaclean, 2015-06-09 19:31:30]

wjmaclean@chromium.org changed reviewers:
+ kenrb@chromium.org

[wjmaclean, 2015-06-09 19:32:40]

kenrb@ - This first patch is meant primarily for running on the bots, but feel
free to take a peek to see if it seems sane.

[wjmaclean, 2015-06-10 14:22:05]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-10 14:22:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169983006/60001

[wjmaclean, 2015-06-10 14:24:03]

wjmaclean@chromium.org changed reviewers:
+ fsamuel@chromium.org, nasko@chromium.org

[wjmaclean, 2015-06-10 15:04:54]

I think this is working properly now, please take a look.

[commit-bot: I haz the power, 2015-06-10 15:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-10 15:18:57]

Dry run: This issue passed the CQ dry run.

[nasko, 2015-06-10 15:45:46]

Ken is much better reviewer for this CL. I'm happy to rubberstamp once he says
it is ready to go.

[kenrb, 2015-06-10 20:43:39]

Just a couple of nits. Did you look into adding a test here?

https://codereview.chromium.org/1169983006/diff/60001/content/browser/frame_h...
File content/browser/frame_host/render_widget_host_view_guest.cc (right):

https://codereview.chromium.org/1169983006/diff/60001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_guest.cc:215: // the guest's
renderer to be composited.
It goes to the embedder's renderer, you mean?

https://codereview.chromium.org/1169983006/diff/60001/content/renderer/child_...
File content/renderer/child_frame_compositing_helper.cc (right):

https://codereview.chromium.org/1169983006/diff/60001/content/renderer/child_...
content/renderer/child_frame_compositing_helper.cc:341: // message.
This is okay, but is there a reason it is done by the BrowserPlugin caller,
rather than just putting it in a different if clause?

[wjmaclean, 2015-06-10 21:05:03]

I'll see if I can devise a suitable test for this pathway (we have indirect
testing via the fact the auto-resize tests are no longer broken by this latest
patch).

See other comments inline.

https://codereview.chromium.org/1169983006/diff/60001/content/browser/frame_h...
File content/browser/frame_host/render_widget_host_view_guest.cc (right):

https://codereview.chromium.org/1169983006/diff/60001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_guest.cc:215: // the guest's
renderer to be composited.
On 2015/06/10 20:43:39, kenrb wrote:
> It goes to the embedder's renderer, you mean?

Oops, yes.

Done.

https://codereview.chromium.org/1169983006/diff/60001/content/renderer/child_...
File content/renderer/child_frame_compositing_helper.cc (right):

https://codereview.chromium.org/1169983006/diff/60001/content/renderer/child_...
content/renderer/child_frame_compositing_helper.cc:341: // message.
On 2015/06/10 20:43:39, kenrb wrote:
> This is okay, but is there a reason it is done by the BrowserPlugin caller,
> rather than just putting it in a different if clause?

I considered adding a new function in the BrowserPlugin so it could be put in a
different if-clause, and I'm still happy to do that.

Originally I thought this would be simpler (no new api and no need to expose
anything about BrowserPlugin's internals).

Done.

[wjmaclean, 2015-06-12 13:59:34]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-12 13:59:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169983006/100001

[commit-bot: I haz the power, 2015-06-12 14:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 14:02:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[wjmaclean, 2015-06-12 14:18:11]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-12 14:18:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169983006/120001

[commit-bot: I haz the power, 2015-06-12 15:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 15:28:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wjmaclean, 2015-06-12 21:00:35]

https://codereview.chromium.org/1169983006/diff/140001/content/browser/frame_...
File content/browser/frame_host/render_widget_host_view_guest_unittest.cc
(right):

https://codereview.chromium.org/1169983006/diff/140001/content/browser/frame_...
content/browser/frame_host/render_widget_host_view_guest_unittest.cc:176:
base::RunLoop().RunUntilIdle();
I'm going to add a comment about why this line is crucial.

[wjmaclean, 2015-06-12 21:00:47]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-12 21:01:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169983006/140001

[kenrb, 2015-06-12 21:02:47]

lgtm

https://codereview.chromium.org/1169983006/diff/100001/content/browser/frame_...
File content/browser/frame_host/render_widget_host_view_guest_unittest.cc
(right):

https://codereview.chromium.org/1169983006/diff/100001/content/browser/frame_...
content/browser/frame_host/render_widget_host_view_guest_unittest.cc:109: void
SwapCompositorFrame(uint32 output_surface_id,
This is probably copied and pasted, but this should be uint32_t.

[wjmaclean, 2015-06-12 21:13:15]

https://codereview.chromium.org/1169983006/diff/100001/content/browser/frame_...
File content/browser/frame_host/render_widget_host_view_guest_unittest.cc
(right):

https://codereview.chromium.org/1169983006/diff/100001/content/browser/frame_...
content/browser/frame_host/render_widget_host_view_guest_unittest.cc:109: void
SwapCompositorFrame(uint32 output_surface_id,
On 2015/06/12 21:02:47, kenrb wrote:
> This is probably copied and pasted, but this should be uint32_t.

Done.

[Fady Samuel, 2015-06-12 21:15:39]

lgtm

[wjmaclean, 2015-06-15 12:36:25]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[wjmaclean, 2015-06-15 12:36:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1169983006/#ps180001
(title: "Update test to always call UpdateGuestSizeIfNecessary().")

[commit-bot: I haz the power, 2015-06-15 12:36:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169983006/180001

[commit-bot: I haz the power, 2015-06-15 14:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 14:04:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nasko, 2015-06-15 16:37:02]

Rubberstamp LGTM

[wjmaclean, 2015-06-15 16:42:46]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2015-06-15 16:43:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169983006/180001

[commit-bot: I haz the power, 2015-06-15 16:49:29]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-06-15 16:50:21]

Patchset 10 (id:??) landed as
https://crrev.com/53032adf732a092a342ae1ef2f3039adf89082d1
Cr-Commit-Position: refs/heads/master@{#334392}