Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1169983005: sky/shell updates for Android and iOS (Closed)

Created:
5 years, 6 months ago by Chinmay
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -572 lines) Patch
M sky/shell/BUILD.gn View 1 chunk +170 lines, -100 lines 1 comment Download
M sky/shell/android/library_loader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D sky/shell/android/org/domokit/sky/shell/PlatformView.java View 1 chunk +0 lines, -189 lines 0 comments Download
A + sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java View 3 chunks +19 lines, -12 lines 0 comments Download
M sky/shell/android/org/domokit/sky/shell/SkyActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
D sky/shell/android/platform_service_provider.h View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/shell/android/platform_service_provider.cc View 1 chunk +0 lines, -45 lines 0 comments Download
A + sky/shell/android/platform_service_provider_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/shell/android/platform_service_provider_android.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D sky/shell/android/platform_view.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/shell/android/platform_view.cc View 1 chunk +0 lines, -81 lines 0 comments Download
A sky/shell/android/platform_view_android.h View 1 chunk +36 lines, -0 lines 0 comments Download
A + sky/shell/android/platform_view_android.cc View 4 chunks +10 lines, -26 lines 0 comments Download
A + sky/shell/platform_view.h View 2 chunks +9 lines, -24 lines 0 comments Download
A sky/shell/platform_view.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M sky/shell/service_provider.h View 1 chunk +3 lines, -6 lines 0 comments Download
M sky/shell/shell.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Chinmay
5 years, 6 months ago (2015-06-09 18:01:20 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/1169983005/diff/1/sky/shell/BUILD.gn File sky/shell/BUILD.gn (right): https://codereview.chromium.org/1169983005/diff/1/sky/shell/BUILD.gn#newcode167 sky/shell/BUILD.gn:167: "ui_delegate.h", Can we avoid having to repeat this ...
5 years, 6 months ago (2015-06-09 18:06:43 UTC) #3
Chinmay
5 years, 6 months ago (2015-06-10 23:20:02 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c544026a51a115ad29e92d5115cabbe034aa391d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698