Source/core/css/parser/CSSParser.cpp - Issue 1169983004: Move fast-path color parsing from CSSPropertyParser to CSSParserFastPaths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParser.cpp

Issue 1169983004: Move fast-path color parsing from CSSPropertyParser to CSSParserFastPaths (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/css-parser/color-escape-parsing.html ('k') | Source/core/css/parser/CSSParserFastPaths.h » ('j') | Source/core/css/parser/CSSParserFastPaths.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSParser.cpp

diff --git a/Source/core/css/parser/CSSParser.cpp b/Source/core/css/parser/CSSParser.cpp

index 88cefa6f0b33bf2cd13a04e9755072e36f695c5a..a67f8ab8dedb352a7717278a1b68fa0746a61876 100644

--- a/Source/core/css/parser/CSSParser.cpp

+++ b/Source/core/css/parser/CSSParser.cpp

@@ -109,7 +109,7 @@ bool CSSParser::parseColor(RGBA32& color, const String& string, bool strict)

return false;

// First try creating a color specified by name, rgba(), rgb() or "#" syntax.

- if (CSSPropertyParser::fastParseColor(color, string, strict))

+ if (CSSParserFastPaths::parseColorAsRGBA32(color, string, !strict))

return true;

// In case the fast-path parser didn't understand the color, try the full parser.