Move fast-path color parsing from CSSPropertyParser to CSSParserFastPaths

Move fast-path color parsing from CSSPropertyParser to CSSParserFastPaths

This patch moves the fast-path color parsing logic in CSSPropertyParser
to CSSParserFastPaths, and updates the call-sites in the property parser
to expicitly call the relevant functions (setNamedColor, parseHexColor).
This also fixes a bug where we would parse color values like \#00ff00
successfully.

BUG=447917, 419270
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196917

[Timothy Loh, 2015-06-09 07:35:19]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org, dstockwell@chromium.org

[alancutter (OOO until 2018), 2015-06-10 00:31:20]

Just nits for now, still reviewing the s/fastParseColor/Color::parseHexColor/
change.

https://codereview.chromium.org/1169983004/diff/20001/Source/core/css/parser/...
File Source/core/css/parser/CSSParserFastPaths.cpp (right):

https://codereview.chromium.org/1169983004/diff/20001/Source/core/css/parser/...
Source/core/css/parser/CSSParserFastPaths.cpp:374: static bool
fastParseColorInternal(RGBA32& rgb, const CharacterType* characters, unsigned
length, bool quirksMode)
parseRGBA32Internal()?

https://codereview.chromium.org/1169983004/diff/20001/Source/core/css/parser/...
File Source/core/css/parser/CSSParserFastPaths.h (right):

https://codereview.chromium.org/1169983004/diff/20001/Source/core/css/parser/...
Source/core/css/parser/CSSParserFastPaths.h:30: static bool
parseColorAsRGBA32(RGBA32&, const String&, bool quirksMode);
Comment could be simpler.
// Resolves keywords like "green".

parseRGBA32()?

Out parameter should be last.

[alancutter (OOO until 2018), 2015-06-10 07:57:00]

lgtm

[Timothy Loh, 2015-06-11 01:30:10]

On 2015/06/10 00:31:20, alancutter wrote:
> Just nits for now, still reviewing the s/fastParseColor/Color::parseHexColor/
> change.
> 
>
https://codereview.chromium.org/1169983004/diff/20001/Source/core/css/parser/...
> File Source/core/css/parser/CSSParserFastPaths.cpp (right):
> 
>
https://codereview.chromium.org/1169983004/diff/20001/Source/core/css/parser/...
> Source/core/css/parser/CSSParserFastPaths.cpp:374: static bool
> fastParseColorInternal(RGBA32& rgb, const CharacterType* characters, unsigned
> length, bool quirksMode)
> parseRGBA32Internal()?
> 
>
https://codereview.chromium.org/1169983004/diff/20001/Source/core/css/parser/...
> File Source/core/css/parser/CSSParserFastPaths.h (right):
> 
>
https://codereview.chromium.org/1169983004/diff/20001/Source/core/css/parser/...
> Source/core/css/parser/CSSParserFastPaths.h:30: static bool
> parseColorAsRGBA32(RGBA32&, const String&, bool quirksMode);
> Comment could be simpler.
> // Resolves keywords like "green".
> 
> parseRGBA32()?
> 
> Out parameter should be last.

Not doing these changes as per in-person discussion. Will be cleaning up this a
bit later (this patch is mostly moving code so I didn't want to do that here),
and so naming and comment wording will change then.

[Timothy Loh, 2015-06-11 01:30:15]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2015-06-11 01:30:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169983004/20001

[commit-bot: I haz the power, 2015-06-11 02:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 02:15:51]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[Timothy Loh, 2015-06-11 03:44:29]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2015-06-11 03:44:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169983004/20001

[commit-bot: I haz the power, 2015-06-11 06:03:04]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196917