Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1169923009: Remove remaining use of the deprecated MessageLoopProxy (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, piman+watch_chromium.org, ben+mojo_chromium.org, mlamouri+watch-media_chromium.org, extensions-reviews_chromium.org, lcwu+watch_chromium.org, abarth-chromium, jbauman+watch_chromium.org, yfriedman+watch_chromium.org, chromium-apps-reviews_chromium.org, jbudorick+watch_chromium.org, cc-bugs_chromium.org, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, kalyank, gunsch+watch_chromium.org, klundberg+watch_chromium.org, darin (slow to review), Ian Vollick, avayvod+watch_chromium.org, mcasas+watch_chromium.org, Aaron Boodman, danakj+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining use of the deprecated MessageLoopProxy This patch removes the remaining usage of MessageLoopProxy outside base/. Note that there are still some call sites for Thread::message_loop_proxy() and MessageLoop::message_loop_proxy() which will be cleaned up separately. BUG=465354 Committed: https://crrev.com/a3899866682a1e846fc978368b00531a0e21d266 Cr-Commit-Position: refs/heads/master@{#334198}

Patch Set 1 #

Patch Set 2 : Add missing includes. #

Patch Set 3 : One more missing include. #

Patch Set 4 : Split out tools/android/. #

Patch Set 5 : Include fix. #

Patch Set 6 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -143 lines) Patch
M chromecast/base/metrics/cast_metrics_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/ble/proximity_auth_ble_system.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/safe_json_parser/safe_json_parser.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_service_client.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M gin/per_isolate_data.h View 3 chunks +3 lines, -5 lines 0 comments Download
M gin/per_isolate_data.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M gin/v8_platform.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_device_unittest.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M media/base/android/media_codec_player.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M mojo/application/public/cpp/lib/content_handler_factory.cc View 1 2 3 4 5 4 chunks +5 lines, -3 lines 0 comments Download
M mojo/common/handle_watcher.cc View 1 2 3 4 5 chunks +7 lines, -10 lines 0 comments Download
M mojo/runner/child_process.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M mojo/runner/in_process_native_runner.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M storage/browser/blob/scoped_file.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/compositor/compositor.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 4 chunks +11 lines, -15 lines 0 comments Download
M win8/metro_driver/chrome_app_view.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/chrome_app_view.cc View 1 2 3 12 chunks +13 lines, -13 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 2 3 4 5 4 chunks +41 lines, -52 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sami
PTAL.
5 years, 6 months ago (2015-06-12 13:20:01 UTC) #2
jam
lgtm
5 years, 6 months ago (2015-06-12 16:32:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169923009/100001
5 years, 6 months ago (2015-06-12 16:36:23 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 6 months ago (2015-06-12 18:22:08 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 18:22:51 UTC) #8
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/a3899866682a1e846fc978368b00531a0e21d266
Cr-Commit-Position: refs/heads/master@{#334198}

Powered by Google App Engine
This is Rietveld 408576698