Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1169923005:
Update oauth2 token endpoint. (Closed)
DescriptionUpdate oauth2 token endpoint.
BUG=487820
Committed: https://crrev.com/dbd7e7360eff348e8b776aa7f887d07e6e1a12a5
Cr-Commit-Position: refs/heads/master@{#333799}
Patch Set 1 #Patch Set 2 : update fake_gaia #Patch Set 3 : Fix local_discovery_ui_browsertest #
Messages
Total messages: 37 (14 generated)
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169923005/1
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169923005/20001
achuith@chromium.org changed reviewers: + alemate@chromium.org
Alex, please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169923005/20001
achuith@chromium.org changed reviewers: + rogerta@chromium.org
Roger, please take a look.
lgtm, assuming failure in LocalDiscoveryUITest.RegisterTest is not related.
On 2015/06/09 21:48:40, Roger Tawa wrote: > lgtm, assuming failure in LocalDiscoveryUITest.RegisterTest is not related. I looked into it, and it doesn't seem to be. I've started another CQ dry run. Thanks for the lg.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Roger, I was wrong, there was a bug in the browsertest. Could you PTAL?
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org Link to the patchset: https://codereview.chromium.org/1169923005/#ps40001 (title: "Fix local_discovery_ui_browsertest")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169923005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Lgtm Thanks for fixing test.
On 2015/06/10 12:41:55, Roger Tawa wrote: > Lgtm > > Thanks for fixing test. Ty!
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169923005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
achuith@chromium.org changed reviewers: + gene@chromium.org
On 2015/06/10 21:02:08, achuithb wrote: Gene, need owner lgtm. Thanks in advance!
lgtm
The CQ bit was checked by achuith@chromium.org
On 2015/06/10 21:03:45, gene wrote: > lgtm ty
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169923005/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/dbd7e7360eff348e8b776aa7f887d07e6e1a12a5 Cr-Commit-Position: refs/heads/master@{#333799} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
